Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade sharp to latest v0.32.6 #38374

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

lovell
Copy link
Contributor

@lovell lovell commented Jul 25, 2023

Description

This PR upgrades all packages to depend on a minimum version of sharp of the latest v0.32.5, which is strongly recommended for those processing untrusted input - please see lovell/sharp#3739

The prebuilt binaries provided with latest version of sharp include zlib-ng v2.1.3, which makes PNG processing much faster, but when encoding can produce a slightly different compressed byte stream when run on different CPUs (the decompressed byte stream is identical). This will affect tests that rely on an exact match of compressed PNG data, hence this PR updating a few tests to compare decoded raw pixel data rather than encoded byte streams.

Tests

This PR updates tests but I have yet to get a completely clean run via CircleCI as a couple of e2e tests appear to be reaching configured timeouts. I can't work out if the failures are related to this change or not.

Too long with no output (exceeded 10m0s): context deadline exceeded

Error: end() took too long (10s)

https://app.circleci.com/pipelines/github/lovell/gatsby/8/workflows/b6962479-f4f8-4ff2-bfea-e8da72cc39ec

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 25, 2023
@pieh pieh added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 26, 2023
Ensures some PNG-related test snapshots use deterministic
raw pixel data rather than non-deterministic compressed byte
streams.
@lovell lovell force-pushed the chore-deps-upgrade-sharp-0.32.4 branch from e5e34a4 to 8d93e33 Compare August 20, 2023 17:49
@lovell lovell changed the title chore(deps): upgrade sharp to latest v0.32.4 chore(deps): upgrade sharp to latest v0.32.5 Aug 20, 2023
@pieh pieh changed the title chore(deps): upgrade sharp to latest v0.32.5 chore(deps): upgrade sharp to latest v0.32.6 Oct 6, 2023
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pieh pieh merged commit ca15ef3 into gatsbyjs:master Oct 6, 2023
32 checks passed
@lovell lovell deleted the chore-deps-upgrade-sharp-0.32.4 branch October 6, 2023 16:02
@lovell
Copy link
Contributor Author

lovell commented Oct 6, 2023

Thanks for updating the version, which means Gatsby will get the libwebp fixes too. lovell/sharp#3798

pieh pushed a commit that referenced this pull request Oct 6, 2023
* chore(deps): upgrade sharp to latest v0.32.5

Ensures some PNG-related test snapshots use deterministic
raw pixel data rather than non-deterministic compressed byte
streams.

* chore(deps): upgrade sharp to latest v0.32.6

---------

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit ca15ef3)
gatsbybot added a commit that referenced this pull request Oct 9, 2023
* chore(deps): upgrade sharp to latest v0.32.5

Ensures some PNG-related test snapshots use deterministic
raw pixel data rather than non-deterministic compressed byte
streams.

* chore(deps): upgrade sharp to latest v0.32.6

---------

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit ca15ef3)

Co-authored-by: Lovell Fuller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

2 participants