fix(gatsby): don't break builds when using features unsupported by adapter #38520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
deleted the
dont-fail-the-build-if-adapter-doesnt-support-a-feature
branch
gatsbybot
added a commit
that referenced
this pull request
Sep 5, 2023
…apter (#38520) (#38521) (cherry picked from commit 6674ad6) Co-authored-by: Michal Piechowiak <[email protected]>
2 tasks
This was referenced Sep 26, 2023
This was referenced Nov 22, 2023
This was referenced Nov 29, 2023
This was referenced Dec 7, 2023
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With release of adapters we introduced a way for adapters to report back if they support handling of
pathPrefixandtrailingSlashoptions. In that release we made gatsby break builds if user options were unsupported by adapter as it did make sense to not allow potentially faulty deploys.However because this wasn't major version bump it can be deemed as breaking change (especially if previously used deployment plugin didn't hard break on their own), so this change stops build failures and instead just prints a warning.
Users might be able to add their own support in some cases (in particular path prefix could be supported on Netlify with https://answers.netlify.com/t/deploy-gatsby-site-to-netlify-with-prefix-paths/1267/6 at least for static assets, but that wouldn't work for DSG/SSR tho, so it's also not full support), so this change unblocks thoes cases.
Documentation
Tests
Related Issues
Fixes: https://github.com/netlify/pillar-support/issues/720