fix(gatsby-adapter-netlify): adapter use headerRoutes (#38652) #38674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplified header rules * lint * lint * update test/snapshot * update snapshot * add snapshot for headerRoutes * adapter use headerRoutes * export type * first pass at headers tests * merge conflict fix * lint error * remove accidental nesting * tests * tests * static assets todo * example of permanent caching header assertion * ensure getServerData header has priority over config header for SSR pages * normalize header values before assertions * add page- and app-data header checks * tmp: skip deleting deploys for easier iteration * refactor test a bit so it's easier to assert same thing in multiple tests + add assertions for js assets * add slice-data headers check * add static query result header test --------- Co-authored-by: Michal Piechowiak <[email protected]> (cherry picked from commit 22c2412)
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
approved these changes
Oct 31, 2023
This was referenced Dec 12, 2023
This was referenced Dec 22, 2023
This was referenced Dec 30, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #38652 to the 5.12 release branch
(cherry picked from commit 22c2412)