Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-plugin-is-child-of-type #3936

Closed
wants to merge 7 commits into from

Conversation

scottyeck
Copy link
Contributor

Sets up environment-specific check for child type detection. See #3486 for context.

@KyleAMathews
Copy link
Contributor

Deploy preview for using-glamor failed.

Built with commit 27e58f0

https://app.netlify.com/sites/using-glamor/deploys/5a7d2f1edf99537d2f894263

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 27e58f0

https://deploy-preview-3936--gatsbygram.netlify.com

@scottyeck
Copy link
Contributor Author

Yeek. Looking at #3864, it looks like this should probably be in gatsby rather than being configured as a plugin. @KyleAMathews if you agree lmk and I can amend the PR.

@KyleAMathews
Copy link
Contributor

Hmm yeah — making this a built-in core util makes sense since it's Gatsby that causes the problem so we should also provide the means to fix it (in again a Gatsby specific way).

@scottyeck
Copy link
Contributor Author

Roger that. 😉

@KyleAMathews
Copy link
Contributor

Hey, would love to have this finished up! Closing out old PRs but please @scottyeck or anyone else interested open a new PR adding a util.

This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants