-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a typo in prop types on README.md #4853
Conversation
What did you fix? Having trouble seeing it for some reason in the diff... |
Deploy preview for using-drupal ready! Built with commit c6fa3b4 |
Sorry :), prop types |
Oh gotcha. Yeah, we write markdown for our website — https://www.gatsbyjs.org/packages/gatsby-image/ but it'd be nice if it works on both — once the preview version finishes loading https://deploy-preview-4853--gatsbyjs.netlify.com/ we can check if the website version still looks good. |
@KyleAMathews can you trigger rebuild for this PR? There was issue in master that was fixed with #4840 but build preview for this PR already failed because of that - https://app.netlify.com/sites/gatsbyjs/deploys/5ac65cb5df99536f76036007 |
Just merged master 👍 |
Hmm yeah, it doesn't look like we need to escape pipes for our markdown compiler (remark) as the back slashes show up now https://deploy-preview-4853--gatsbyjs.netlify.com/packages/gatsby-image/?=image We expect people to read docs on the website so I'll close this. It's unfortunate that the markdown rendering differs sometimes. |
No description provided.