[v2] fix eslint warnings #5121
[v2] fix eslint warnings #5121
Conversation
| @@ -119,11 +118,13 @@ async function findGraphQLTags(file, text): Promise<Array<DefinitionNode>> { | |||
| TaggedTemplateExpression(path) { | |||
| if ( | |||
| (`descendant of query`, | |||
| // eslint-disable-next-line no-undef | |||
There was a problem hiding this comment.
Couldn't figure out how to get babel-eslint to like the optional chaining here.
There was a problem hiding this comment.
Yeah, noticed that too — it must not be setup to use or repo babel setup
There was a problem hiding this comment.
There is one specific minor version that it works with...I'll find it I have it set in another project but don't remember off the top of my head :P
There was a problem hiding this comment.
that'd be ace, thanks :D
There was a problem hiding this comment.
its 8.2.1 and earlier i think, you can pin to that specific version tho, any higher and it's broken. babel/babel-eslint#595
There was a problem hiding this comment.
Updated, thanks!
packages/gatsby/src/redux/actions.js
Outdated
| @@ -347,12 +345,6 @@ actions.deleteNodes = (nodes: any[], plugin: Plugin) => { | |||
| plugin, | |||
| payload: nodes, | |||
| } | |||
|
|
|||
| if (deleteDescendantsActions) { | |||
There was a problem hiding this comment.
Removed this as eslint marked it as unreachable. Should deleting descendants still be included?
There was a problem hiding this comment.
Yeah — this might be a bad merge. If you look at deleteNode, it finds descendant nodes to delete above.
There was a problem hiding this comment.
I've reverted this, handling it in #5106 instead.
|
This is ready for another look. |
|
🙏nice work! |
* Fix lint errors * Revert this, handled in PR 5106 * Pin babel-eslint to a version that supports @babel/plugin-proposal-optional-chaining
buildanddevelopworks locally on gatsbygram, I've not tested these changes any further.