fix(contentful): properly delete deleted entries and assets #5756
Conversation
|
Deploy preview for gatsbygram ready! Built with commit b23923a |
|
Deploy preview for using-drupal ready! Built with commit b23923a |
| @@ -75,12 +75,17 @@ exports.sourceNodes = async ( | |||
| // Remove deleted entries & assets. | |||
| // TODO figure out if entries referencing now deleted entries/assets | |||
| // are "updated" so will get the now deleted reference removed. | |||
|
|
|||
| function deleteContentfulNode (node) { | |||
| const id = normalize.fixId(node.sys.id) | |||
There was a problem hiding this comment.
isn't normalize.fixId already done here - https://github.com/axe312ger/gatsby/blob/3058f95dc020524dec1242da3523a1e9a5f73e5d/packages/gatsby-source-contentful/src/fetch.js#L75-L86 (fixIds seem to traverse passed object and run fixId on id fields) ?
There was a problem hiding this comment.
Also the id is passed to your new function not the node. You need to fix the id and then use that to get the node.
There was a problem hiding this comment.
node is passed there - lines that maps node -> id are deleted ( lines 79, 82 ), but I checked again and we can skip normalizing id here (it's already normalized)
|
Tested it locally and this now properly deletes nodes for deleted entries of non-default locales. But I couldn't replicate exact issue presented in #5747 (nodes with null fields). I would see nodes that should be deleted but containing all data before applying changes from this PR. |
|
I removed the |
* master: (26 commits) Publish [feat] Extract internal plugin for automatically creating pages so we can reuse for other directories (#4490) fix(contentful): properly delete deleted entries and assets (#5756) Fix typo add Linda's post (#5817) [gatsby-source-contentful] Fix prepareJSONNode for array normalization (#5107) Process Contentful images inlined in markdown (#5542) feat(contentful): add traced SVGs to Contentful images (#5659) [SQIP] Add documentation (#5287) Add site to showcase (#5819) [gatsby-remark-copy-linked-files] Support reference-style images (#5818) Update docs for gatsby-plugin-catch-links (#5843) Added ⋅ representing a space to sub-list examples to reflect actual code (#5829) Adding tigerfacilityservices.com to showcase (#5855) fix schema type conflict reporter regressions (#5805) [gatsby-plugin-feed] Support nested output directory (#5820) Make cache available to the plugins (#5840) [gatsby-source-contentful] update data and jest snapshots (#5802) [gatsby-plugin-manifest] Replace all manifest.json with manifest.webmanifest in comments/docs (#5157) Update deploy-gatsby.md (#5800) ... # Conflicts: # docs/tutorial/part-one/index.md # examples/using-sqip/src/components/polaroid.js # packages/gatsby-image/README.md # packages/gatsby-image/package.json # packages/gatsby-plugin-catch-links/package.json # packages/gatsby-plugin-feed/package.json # packages/gatsby-plugin-manifest/package.json # packages/gatsby-plugin-page-creator/src/gatsby-node.js # packages/gatsby-remark-copy-linked-files/package.json # packages/gatsby-source-contentful/package.json # packages/gatsby-source-contentful/src/__tests__/__snapshots__/normalize.js.snap # packages/gatsby-source-contentful/src/extend-node-type.js # packages/gatsby-source-contentful/src/gatsby-node.js # packages/gatsby-source-contentful/src/normalize.js # packages/gatsby-transformer-remark/package.json # packages/gatsby-transformer-remark/src/__tests__/__snapshots__/gatsby-node.js.snap # packages/gatsby-transformer-sqip/package.json # packages/gatsby-transformer-sqip/src/extend-node-type.js # packages/gatsby/package.json # packages/gatsby/src/bootstrap/load-plugins/__tests__/__snapshots__/load-plugins.js.snap # packages/gatsby/src/bootstrap/load-plugins/load.js # www/src/data/sites.yml
fixes #5747
This should ensure that the correct id's are passed to deleteNode