Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add typography changes to migration guide #6151

Merged
merged 3 commits into from
Jun 28, 2018
Merged

docs: add typography changes to migration guide #6151

merged 3 commits into from
Jun 28, 2018

Conversation

NickyMeuleman
Copy link
Contributor

@NickyMeuleman NickyMeuleman commented Jun 25, 2018

Add info about changes to the typography utils file to the migration guide for moving from v1 to v2.

edit: woah, hold on, seeing changes in that file I didn't make (the what we'll cover section)
A markdown extension in my editor changed the table-of-contents, changed it back, we're all good now!

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 25, 2018

Deploy preview for gatsbygram ready!

Built with commit f68da8e

https://deploy-preview-6151--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 25, 2018

Deploy preview for using-drupal ready!

Built with commit f68da8e

https://deploy-preview-6151--using-drupal.netlify.com

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NickyMeuleman! Apologies for the delay reviewing this. I'm a bit hesitant to include the change like this as I think (although I'm not certain) that this is related to using babel 7 rather than being a plugin specific change.

As this is definitely useful information for people upgrading their sites, I'm going to merge as-is and maybe we can revisit it later.

@m-allanson m-allanson merged commit 261286a into gatsbyjs:master Jun 28, 2018
@jlengstorf
Copy link
Contributor

Hiya @NickyMeuleman! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants