Support page data declared as named exports #838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not entirely sure if you'd like to accept this PR, given the new GraphQL data layer, but I find it a little more pleasant to write
export const data = { foo: 'bar' }
instead ofexports.data = { foo: 'bar' }
, but that may just be me 😅By the way, whilst playing around with this part of the code, I discovered that any assignment to a
data
MemberExpression
gets picked up byload-frontmatter
, even things likeSaying that, I thought fixing that might be slightly out of scope for this PR..