Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin dashboard issue#25 #36

Conversation

Kashif-Saleem-Ghuman
Copy link
Contributor

@Kashif-Saleem-Ghuman Kashif-Saleem-Ghuman commented Sep 1, 2023

Hi Code Reviewer 👋
Animated GIF
🟢 In this milestone:

  • I have created the Dashboard. Here is a video demonstration of what I have implemented:
    Video Demonstartion

closes #25

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for visionary-fenglisu-db1b1d ready!

Name Link
🔨 Latest commit d3e6209
🔍 Latest deploy log https://app.netlify.com/sites/visionary-fenglisu-db1b1d/deploys/64fff0c38feab70008a2d7e6
😎 Deploy Preview https://deploy-preview-36--visionary-fenglisu-db1b1d.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Kashif-Saleem-Ghuman
Copy link
Contributor Author

HI @gauravsingh1281,

Hope you are well! Kindly review the PR.

Regards,
Kashif Saleem

@gauravsingh1281
Copy link
Owner

gauravsingh1281 commented Sep 8, 2023

Hey @Kashif-Saleem-Ghuman I have looked at your PR and found that u have made some changes in the homepage's navbar and made it different from its Figma design. So Please make it look like the Figma design that I have provided.

@gauravsingh1281
Copy link
Owner

@Kashif-Saleem-Ghuman And the admin dashboard page comes after user authentication which means that when the user is successfully logged in than it will redirect to the admin dashboard.

@Kashif-Saleem-Ghuman
Copy link
Contributor Author

Hi @gauravsingh1281 ,

I have refactored as per your suggestions. Please check.

@gauravsingh1281
Copy link
Owner

@Kashif-Saleem-Ghum
Fix the homepage's navbar and make it look like the Figma design that I have provided.
Figma Design - https://www.figma.com/file/9WhtUQT7s5ogTiDTp90PxI/RENTALOG-WEB-DESIGN?type=design&node-id=0-1&mode=design&t=giHe43ij31sBYaaw-0

@gauravsingh1281
Copy link
Owner

gauravsingh1281 commented Sep 13, 2023

Screenshot 2023-09-13 195006

@Kashif-Saleem-Ghuman You're not understanding what I mean. I only want you to remove the white background from the navbar so that it matches the Figma design and header section background color.

Final design link - https://visionary-fenglisu-db1b1d.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design and Create Rentalog Admin Dashboard.
2 participants