Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed navbar responsiveness #38

Merged

Conversation

vashukashyap
Copy link
Contributor

What this PR do?

#21 fixed Navbar responsive for both desktop and mobile.

Expected behaviour.

the Navbar should display properly on desktop and mobile

Additional info.

Desktop

Screenshot (16)

Mobile

Screenshot (17)
Screenshot (18)

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for visionary-fenglisu-db1b1d ready!

Name Link
🔨 Latest commit b231329
🔍 Latest deploy log https://app.netlify.com/sites/visionary-fenglisu-db1b1d/deploys/652adfdf9892c800087ba4f9
😎 Deploy Preview https://deploy-preview-38--visionary-fenglisu-db1b1d.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @vashukashyap! 🎉 Thank you for submitting your pull request for Rentalog. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@vashukashyap
Copy link
Contributor Author

Kindly check my PR please

Copy link
Collaborator

@Iamdivyak Iamdivyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give the navbar background a blur effect on scrolling.
give a 1.5rem margin to the 'close menu' button

Copy link
Collaborator

@Iamdivyak Iamdivyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give the navbar background a blur effect on scrolling.
give a 1.5rem margin to the 'close menu' button

@vashukashyap
Copy link
Contributor Author

I have committed the changes, can you review it please

@gauravsingh1281
Copy link
Owner

Screenshot 2023-10-14 200757 Screenshot 2023-10-14 200901

Hii @vashukashyap rentals nav links missing in the navbar and I want the above mobile design for mobile view.

@vashukashyap
Copy link
Contributor Author

I have modified the Navbar , please review now.

@gauravsingh1281
Copy link
Owner

I have modified the Navbar , please review now.

@vashukashyap please resolve merge conflict.

@vashukashyap
Copy link
Contributor Author

I have resolved the merge conflict. review it please!

@gauravsingh1281 gauravsingh1281 merged commit 9b2727c into gauravsingh1281:main Oct 14, 2023
5 checks passed
@gauravsingh1281
Copy link
Owner

Thank you for your contribution @vashukashyap

@vashukashyap
Copy link
Contributor Author

thankyou sir, is there any other issue where I can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants