-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed navbar responsiveness #38
fixed navbar responsiveness #38
Conversation
✅ Deploy Preview for visionary-fenglisu-db1b1d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @vashukashyap! 🎉 Thank you for submitting your pull request for Rentalog. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.
Kindly check my PR please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
give the navbar background a blur effect on scrolling.
give a 1.5rem margin to the 'close menu' button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
give the navbar background a blur effect on scrolling.
give a 1.5rem margin to the 'close menu' button
I have committed the changes, can you review it please |
Hii @vashukashyap rentals nav links missing in the navbar and I want the above mobile design for mobile view. |
I have modified the Navbar , please review now. |
@vashukashyap please resolve merge conflict. |
I have resolved the merge conflict. review it please! |
Thank you for your contribution @vashukashyap |
thankyou sir, is there any other issue where I can help? |
What this PR do?
#21 fixed Navbar responsive for both desktop and mobile.
Expected behaviour.
the Navbar should display properly on desktop and mobile
Additional info.
Desktop
Mobile