Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source the libraries before executing the tests #24

Closed
wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 17, 2020

We are having some problem with the ignition-sensors tests. When we are executing the tests some libraries are not availables. This is because the ignition libraries are not sourced.

This should be ported to master too.

@chapulina @j-rivero

Signed-off-by: ahcorde [email protected]

@@ -154,6 +154,7 @@ fi
echo ::group::make test
export CTEST_OUTPUT_ON_FAILURE=1
cd "$GITHUB_WORKSPACE"/build
. colcon_command_prefix_test.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only part of the code that uses colcon is when compiling dependencies from source, see line 93 above. And that's sourcing the workspace. I'm not sure what this line is supposed to be doing.

The PR you mentioned, gazebosim/gz-sensors#38, isn't installing any dependencies from source, so that build shouldn't need colcon at all.

Maybe what you need is a make install on after_make.sh like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 93 only source the dependencies if you include some dependencies from source.

This file is only going to load the package.sh of the dependencies included in the CMakeLists.txt. An example:

# generated from colcon_core/shell/template/command_prefix.sh.em
. "/home/ahcorde/ignition_dome/install/share/ignition-cmake2/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-math6/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-plugin1/package.sh"
. "/home/ahcorde/ignition_dome/install/share/ignition-rendering4/package.sh"

This other approach may require:

  • include -DCMAKE_INSTALL_PREFIX to the cmake call
  • source this directoryif it's not default one
  • and make install
    or
  • make install
  • setup manually LD_LIBRARY_PATH because make install will install this new library in /usr/local not in /usr/ . See here

@ahcorde ahcorde closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants