-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps in garden : ign-plugin2 #81
Conversation
Signed-off-by: Brandon Ong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @methylDragon ! This repository is not very friendly with respect to propagate changes to other files in Garden using declaring ign-plugin as a dependency. Does any other of the bumps in Garden at this time is going to use ign-plugin? Using a quick check for guidance:
gazebodistro on master [?] ❯ grep -R utils * | awk '{ print $1}' | sort | uniq
collection-edifice.yaml:
collection-fortress.yaml:
collection-garden.yaml:
ign-common4.yaml:
ign-common5.yaml:
ign-fuel-tools8.yaml:
ign-gazebo5.yaml:
ign-gazebo6.yaml:
ign-gazebo7.yaml:
ign-gui5.yaml:
ign-gui6.yaml:
ign-gui7.yaml:
ign-launch4.yaml:
ign-launch5.yaml:
ign-launch6.yaml:
ign-math7.yaml:
ign-msgs9.yaml:
ign-physics4.yaml:
ign-physics5.yaml:
ign-physics6.yaml:
ign-plugin2.yaml:
ign-rendering5.yaml:
ign-rendering6.yaml:
ign-rendering7.yaml:
ign-sensors5.yaml:
ign-sensors6.yaml:
ign-sensors7.yaml:
ign-transport10.yaml:
ign-transport11.yaml:
ign-transport12.yaml:
ign-utils1.yaml:
ign-utils2.yaml:
sdformat11.yaml:
sdformat12.yaml:
sdformat13.yaml:
At least the collection-garden file needs to be change IMHO. Could you please check if we need to bump any other? Thanks!
Erm... There will be a bump following this one that will bump ign-cmake3, ign-utils2, ign-tools2, ign-plugin2, which means practically every library will get bumped :/ But this first wave will bump ign-cmake3, ign-util2, ign-plugin2, which no other libraries will be relying on, in my understanding (since they'll be relying on Hopefully I got that right, I'm still a little unfamiliar with the ign libs |
Just to add to what @methylDragon said, we'll be opening PRs for each library separately even for the next wave, because that makes it easier to merge them in order. It's like we did for the previous Garden bumps: https://github.com/ignition-tooling/gazebodistro/pulls?q=is%3Apr+is%3Aclosed+bumps+in+garden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, thanks for the info.
See gazebo-tooling/release-tools#685