Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign-sensors[6,7] don't depend on ign-plugin #82

Closed
wants to merge 1 commit into from

Conversation

chapulina
Copy link
Contributor

The dependency was removed in this PR:

But we forgot to update gazebodistro.

Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ign-plugin is not a direct dependency, but it is a recursive dependency via ign-rendering

@chapulina
Copy link
Contributor Author

Ahh nice catch, @scpeters . Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants