Skip to content

Commit

Permalink
Merge branch 'master' into jrivero/avoid_no_numToKeep
Browse files Browse the repository at this point in the history
  • Loading branch information
j-rivero authored Oct 8, 2024
2 parents bf87b3f + 606af28 commit 8344708
Show file tree
Hide file tree
Showing 8 changed files with 304 additions and 31 deletions.
68 changes: 62 additions & 6 deletions check_releasepy.bash
Original file line number Diff line number Diff line change
@@ -1,9 +1,22 @@
#!/bin/bash -e

test_dir=$(mktemp -d)
mkdir -p ${test_dir}/{focal,jammy,ubuntu}/debian
export _RELEASEPY_TEST_RELEASE_REPO=${test_dir}
export _RELEASEPY_DEBUG=1
test_dir=$(mktemp -d)
export _RELEASEPY_TEST_RELEASE_REPO="${test_dir}/test-release"
mkdir -p ${_RELEASEPY_TEST_RELEASE_REPO}/{focal,jammy,ubuntu}/debian
export _RELEASEPY_TEST_SOURCE_REPO="${test_dir}/src"
mkdir -p ${_RELEASEPY_TEST_SOURCE_REPO}
# Fake packages.xml to make the vendor package script happy
cat > "${_RELEASEPY_TEST_SOURCE_REPO}/package.xml" <<-EOF
<?xml version="1.0"?>
<package format="2">
<name>gz-foo</name>
<version>0.0.0</version>
<description>test</description>
<maintainer email="[email protected]">Testing maintainer</maintainer>
<license>Foo License</license>
</package>
EOF

exec_releasepy_test()
{
Expand All @@ -12,7 +25,7 @@ exec_releasepy_test()
./release.py \
--dry-run \
--no-sanity-checks \
gz-foo 1.2.3 token ${test_params}""
gz-foo 1.2.3 token ${test_params}
}

exec_ignition_releasepy_test()
Expand All @@ -22,7 +35,7 @@ exec_ignition_releasepy_test()
./release.py \
--dry-run \
--no-sanity-checks \
ign-foo 1.2.3 token ${test_params}""
ign-foo 1.2.3 token ${test_params}
}

exec_ignition_gazebo_releasepy_test()
Expand All @@ -32,7 +45,18 @@ exec_ignition_gazebo_releasepy_test()
./release.py \
--dry-run \
--no-sanity-checks \
ign-gazebo 1.2.3 token ${test_params}""
ign-gazebo 1.2.3 token ${test_params}
}

exec_releasepy_with_real_gz()
{
gz_pkg=${1} major_version=${2}
./release.py \
--dry-run \
--no-sanity-checks \
--source-repo-uri http://github.com/gazebosim/gz-common \
--source-repo-existing-ref http://github.com/gazebosim/gz-common/foo-tag \
"${gz_pkg}" "${major_version}.x.y" token
}

expect_job_run()
Expand Down Expand Up @@ -73,35 +97,58 @@ expect_param()
echo "${param} not found in test output"
exit 1
fi
}

expect_vendor_repo()
{
output="${1}" repo="${2}"

if ! grep -q "Github ${repo}" <<< "${output}"; then
echo "${repo} not found in test output"
exit 1
fi
}

expect_no_vendor()
{
output="${1}"

if grep -q 'in ROS 2' <<< "${output}"; then
echo "ROS 2 string found in output"
exit 1
fi
}

source_repo_uri_test=$(exec_releasepy_test "--source-repo-uri https://github.com/gazebosim/gz-foo.git")
expect_job_run "${source_repo_uri_test}" "gz-foo-source"
expect_job_not_run "${source_repo_uri_test}" "gz-foo-debbuilder"
expect_number_of_jobs "${source_repo_uri_test}" "1"
expect_param "${source_repo_uri_test}" "SOURCE_REPO_URI=https%3A%2F%2Fgithub.com%2Fgazebosim%2Fgz-foo.git"
expect_no_vendor "${source_repo_uri_test}" # non existing package

source_tarball_uri_test=$(exec_releasepy_test "--source-tarball-uri https://gazebosim/gz-foo-1.2.3.tar.gz")
expect_job_run "${source_tarball_uri_test}" "gz-foo-debbuilder"
expect_job_run "${source_tarball_uri_test}" "generic-release-homebrew_pull_request_updater"
expect_job_not_run "${source_tarball_uri_test}" "gz-foo-source"
expect_number_of_jobs "${source_tarball_uri_test}" "7"
expect_param "${source_tarball_uri_test}" "SOURCE_TARBALL_URI=https%3A%2F%2Fgazebosim%2Fgz-foo-1.2.3.tar.gz"
expect_no_vendor "${source_tarball_uri_test}"

nightly_test=$(exec_releasepy_test "--nightly-src-branch my-nightly-branch3 --upload-to-repo nightly")
expect_job_run "${nightly_test}" "gz-foo-debbuilder"
expect_job_not_run "${nightly_test}" "generic-release-homebrew_pull_request_updater"
expect_job_not_run "${nightly_test}" "gz-foo-source"
expect_number_of_jobs "${nightly_test}" "2"
expect_param "${nightly_test}" "SOURCE_TARBALL_URI=my-nightly-branch3"
expect_no_vendor "${nightly_test}"

bump_linux_test=$(exec_releasepy_test "--source-tarball-uri https://gazebosim/gz-foo-1.2.3.tar.gz --only-bump-revision-linux -r 2")
expect_job_run "${bump_linux_test}" "gz-foo-debbuilder"
expect_job_not_run "${bump_linux_test}" "generic-release-homebrew_pull_request_updater"
expect_job_not_run "${bump_linux_test}" "gz-foo-source"
expect_number_of_jobs "${bump_linux_test}" "6"
expect_param "${bump_linux_test}" "RELEASE_VERSION=2"
expect_no_vendor "${bump_linux_test}"

ignition_test=$(exec_ignition_releasepy_test "--source-repo-uri https://github.com/gazebosim/gz-foo.git")
expect_job_run "${ignition_test}" "gz-foo-source"
Expand All @@ -128,3 +175,12 @@ expect_number_of_jobs "${ign_gazebo_source_tarball_uri_test}" "7"
expect_param "${ign_gazebo_source_tarball_uri_test}" "SOURCE_TARBALL_URI=https%3A%2F%2Fgazebosim%2Fign-gazebo-1.2.3.tar.gz"
expect_param "${ign_gazebo_source_tarball_uri_test}" "PACKAGE=ign-gazebo"
expect_param "${ign_gazebo_source_tarball_uri_test}" "PACKAGE_ALIAS=ignition-gazebo"

ros_vendor_test=$(exec_releasepy_with_real_gz gz-fuel-tools 9)
expect_vendor_repo "${ros_vendor_test}" gazebo-release/gz_fuel_tools_vendor

ros_vendor_test=$(exec_releasepy_with_real_gz gz-cmake 2)
expect_no_vendor "${ros_vendor_test}"

ros_vendor_test=$(exec_releasepy_with_real_gz gz-ionic 3)
expect_no_vendor "${ros_vendor_test}"
1 change: 1 addition & 0 deletions jenkins-scripts/docker/lib/docker_generate_dockerfile.bash
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ fi

echo '# BEGIN SECTION: create the Dockerfile'
cat > Dockerfile << DELIM_DOCKER
#!/bin/bash
#######################################################
# Docker file to run build.sh
Expand Down
1 change: 1 addition & 0 deletions jenkins-scripts/dsl/_configs_/OSRFLinuxCompilation.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ class OSRFLinuxCompilation extends OSRFLinuxBase
filters {
'io.jenkins.plugins.analysis.core.filter.ExcludeFile' {
pattern('.*ALSA lib.*')
pattern('\\d+: \\(')
}
}
isEnabledForFailure(false)
Expand Down
2 changes: 1 addition & 1 deletion jenkins-scripts/dsl/brew_release.dsl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import javaposse.jobdsl.dsl.Job
Globals.default_emails = "[email protected], [email protected]"

// first distro in list is used as touchstone
brew_supported_distros = [ "monterey", "ventura" ]
brew_supported_distros = [ "ventura", "sonoma" ]
bottle_hash_updater_job_name = 'generic-release-homebrew_pr_bottle_hash_updater'
bottle_builder_job_name = 'generic-release-homebrew_triggered_bottle_builder'
directory_for_bottles = 'pkgs'
Expand Down
24 changes: 20 additions & 4 deletions jenkins-scripts/dsl/gz-collections.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ collections:
- name: gz-common
major_version: 6
repo:
current_branch: main
current_branch: gz-common6
- name: gz-msgs
major_version: 11
repo:
Expand Down Expand Up @@ -411,15 +411,15 @@ collections:
- name: gz-physics
major_version: 8
repo:
current_branch: main
current_branch: gz-physics8
- name: gz-sim
major_version: 9
repo:
current_branch: main
current_branch: gz-sim9
- name: gz-launch
major_version: 8
repo:
current_branch: main
current_branch: gz-launch8
- name: gz-ionic
major_version: 1
repo:
Expand Down Expand Up @@ -449,6 +449,10 @@ collections:
major_version: 4
repo:
current_branch: main
- name: gz-common
major_version: 6
repo:
current_branch: main
- name: gz-fuel-tools
major_version: 10
repo:
Expand All @@ -457,6 +461,10 @@ collections:
major_version: 9
repo:
current_branch: main
- name: gz-launch
major_version: 8
repo:
current_branch: main
- name: gz-math
major_version: 8
repo:
Expand All @@ -465,6 +473,10 @@ collections:
major_version: 11
repo:
current_branch: main
- name: gz-physics
major_version: 8
repo:
current_branch: main
- name: gz-plugin
major_version: 3
repo:
Expand All @@ -477,6 +489,10 @@ collections:
major_version: 9
repo:
current_branch: main
- name: gz-sim
major_version: 9
repo:
current_branch: main
- name: gz-transport
major_version: 14
repo:
Expand Down
56 changes: 40 additions & 16 deletions jenkins-scripts/dsl/logs/generated_jobs.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
asan_ci __upcoming__ gz_cmake-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_common-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_fuel_tools-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_gui-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_launch-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_math-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_msgs-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_physics-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_plugin-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_rendering-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_sensors-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_sim-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_tools-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_transport-ci_asan-main-noble-amd64
asan_ci __upcoming__ gz_utils-ci_asan-main-noble-amd64
Expand Down Expand Up @@ -74,36 +78,45 @@ asan_ci harmonic gz_transport-ci_asan-gz-transport13-jammy-amd64
asan_ci harmonic gz_utils-ci_asan-gz-utils2-jammy-amd64
asan_ci harmonic sdformat-ci_asan-sdf14-jammy-amd64
asan_ci ionic gz_cmake-ci_asan-gz-cmake4-noble-amd64
asan_ci ionic gz_common-ci_asan-main-noble-amd64
asan_ci ionic gz_common-ci_asan-gz-common6-noble-amd64
asan_ci ionic gz_fuel_tools-ci_asan-gz-fuel-tools10-noble-amd64
asan_ci ionic gz_gui-ci_asan-gz-gui9-noble-amd64
asan_ci ionic gz_launch-ci_asan-main-noble-amd64
asan_ci ionic gz_launch-ci_asan-gz-launch8-noble-amd64
asan_ci ionic gz_math-ci_asan-gz-math8-noble-amd64
asan_ci ionic gz_msgs-ci_asan-gz-msgs11-noble-amd64
asan_ci ionic gz_physics-ci_asan-main-noble-amd64
asan_ci ionic gz_physics-ci_asan-gz-physics8-noble-amd64
asan_ci ionic gz_plugin-ci_asan-gz-plugin3-noble-amd64
asan_ci ionic gz_rendering-ci_asan-gz-rendering9-noble-amd64
asan_ci ionic gz_sensors-ci_asan-gz-sensors9-noble-amd64
asan_ci ionic gz_sim-ci_asan-main-noble-amd64
asan_ci ionic gz_sim-ci_asan-gz-sim9-noble-amd64
asan_ci ionic gz_tools-ci_asan-gz-tools2-noble-amd64
asan_ci ionic gz_transport-ci_asan-gz-transport14-noble-amd64
asan_ci ionic gz_utils-ci_asan-gz-utils3-noble-amd64
asan_ci ionic sdformat-ci_asan-sdf15-noble-amd64
branch_ci __upcoming__ gz_cmake-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_cmake-ci-main-noble-amd64
branch_ci __upcoming__ gz_cmake-main-win
branch_ci __upcoming__ gz_common-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_common-ci-main-noble-amd64
branch_ci __upcoming__ gz_common-main-win
branch_ci __upcoming__ gz_fuel_tools-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_fuel_tools-ci-main-noble-amd64
branch_ci __upcoming__ gz_fuel_tools-main-win
branch_ci __upcoming__ gz_gui-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_gui-ci-main-noble-amd64
branch_ci __upcoming__ gz_gui-main-win
branch_ci __upcoming__ gz_launch-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_launch-ci-main-noble-amd64
branch_ci __upcoming__ gz_launch-main-win
branch_ci __upcoming__ gz_math-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_math-ci-main-noble-amd64
branch_ci __upcoming__ gz_math-main-win
branch_ci __upcoming__ gz_msgs-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_msgs-ci-main-noble-amd64
branch_ci __upcoming__ gz_msgs-main-win
branch_ci __upcoming__ gz_physics-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_physics-ci-main-noble-amd64
branch_ci __upcoming__ gz_physics-main-win
branch_ci __upcoming__ gz_plugin-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_plugin-ci-main-noble-amd64
branch_ci __upcoming__ gz_plugin-main-win
Expand All @@ -113,6 +126,9 @@ branch_ci __upcoming__ gz_rendering-main-win
branch_ci __upcoming__ gz_sensors-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_sensors-ci-main-noble-amd64
branch_ci __upcoming__ gz_sensors-main-win
branch_ci __upcoming__ gz_sim-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_sim-ci-main-noble-amd64
branch_ci __upcoming__ gz_sim-main-win
branch_ci __upcoming__ gz_tools-ci-main-homebrew-amd64
branch_ci __upcoming__ gz_tools-ci-main-noble-amd64
branch_ci __upcoming__ gz_tools-main-win
Expand Down Expand Up @@ -331,27 +347,27 @@ branch_ci harmonic sdformat-sdf14-win
branch_ci ionic gz_cmake-4-win
branch_ci ionic gz_cmake-ci-gz-cmake4-homebrew-amd64
branch_ci ionic gz_cmake-ci-gz-cmake4-noble-amd64
branch_ci ionic gz_common-ci-main-homebrew-amd64
branch_ci ionic gz_common-ci-main-noble-amd64
branch_ci ionic gz_common-main-win
branch_ci ionic gz_common-6-win
branch_ci ionic gz_common-ci-gz-common6-homebrew-amd64
branch_ci ionic gz_common-ci-gz-common6-noble-amd64
branch_ci ionic gz_fuel_tools-10-win
branch_ci ionic gz_fuel_tools-ci-gz-fuel-tools10-homebrew-amd64
branch_ci ionic gz_fuel_tools-ci-gz-fuel-tools10-noble-amd64
branch_ci ionic gz_gui-9-win
branch_ci ionic gz_gui-ci-gz-gui9-homebrew-amd64
branch_ci ionic gz_gui-ci-gz-gui9-noble-amd64
branch_ci ionic gz_launch-ci-main-homebrew-amd64
branch_ci ionic gz_launch-ci-main-noble-amd64
branch_ci ionic gz_launch-main-win
branch_ci ionic gz_launch-8-win
branch_ci ionic gz_launch-ci-gz-launch8-homebrew-amd64
branch_ci ionic gz_launch-ci-gz-launch8-noble-amd64
branch_ci ionic gz_math-8-win
branch_ci ionic gz_math-ci-gz-math8-homebrew-amd64
branch_ci ionic gz_math-ci-gz-math8-noble-amd64
branch_ci ionic gz_msgs-11-win
branch_ci ionic gz_msgs-ci-gz-msgs11-homebrew-amd64
branch_ci ionic gz_msgs-ci-gz-msgs11-noble-amd64
branch_ci ionic gz_physics-ci-main-homebrew-amd64
branch_ci ionic gz_physics-ci-main-noble-amd64
branch_ci ionic gz_physics-main-win
branch_ci ionic gz_physics-8-win
branch_ci ionic gz_physics-ci-gz-physics8-homebrew-amd64
branch_ci ionic gz_physics-ci-gz-physics8-noble-amd64
branch_ci ionic gz_plugin-3-win
branch_ci ionic gz_plugin-ci-gz-plugin3-homebrew-amd64
branch_ci ionic gz_plugin-ci-gz-plugin3-noble-amd64
Expand All @@ -361,9 +377,9 @@ branch_ci ionic gz_rendering-ci-gz-rendering9-noble-amd64
branch_ci ionic gz_sensors-9-win
branch_ci ionic gz_sensors-ci-gz-sensors9-homebrew-amd64
branch_ci ionic gz_sensors-ci-gz-sensors9-noble-amd64
branch_ci ionic gz_sim-ci-main-homebrew-amd64
branch_ci ionic gz_sim-ci-main-noble-amd64
branch_ci ionic gz_sim-main-win
branch_ci ionic gz_sim-9-win
branch_ci ionic gz_sim-ci-gz-sim9-homebrew-amd64
branch_ci ionic gz_sim-ci-gz-sim9-noble-amd64
branch_ci ionic gz_tools-2-win
branch_ci ionic gz_tools-ci-gz-tools2-homebrew-amd64
branch_ci ionic gz_tools-ci-gz-tools2-noble-amd64
Expand All @@ -378,20 +394,28 @@ branch_ci ionic sdformat-ci-sdf15-noble-amd64
branch_ci ionic sdformat-sdf15-win
install_ci __upcoming__ gz_cmake4-install-pkg-noble-amd64
install_ci __upcoming__ gz_cmake4-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_common6-install-pkg-noble-amd64
install_ci __upcoming__ gz_common6-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_fuel_tools10-install-pkg-noble-amd64
install_ci __upcoming__ gz_fuel_tools10-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_gui9-install-pkg-noble-amd64
install_ci __upcoming__ gz_gui9-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_launch8-install-pkg-noble-amd64
install_ci __upcoming__ gz_launch8-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_math8-install-pkg-noble-amd64
install_ci __upcoming__ gz_math8-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_msgs11-install-pkg-noble-amd64
install_ci __upcoming__ gz_msgs11-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_physics8-install-pkg-noble-amd64
install_ci __upcoming__ gz_physics8-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_plugin3-install-pkg-noble-amd64
install_ci __upcoming__ gz_plugin3-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_rendering9-install-pkg-noble-amd64
install_ci __upcoming__ gz_rendering9-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_sensors9-install-pkg-noble-amd64
install_ci __upcoming__ gz_sensors9-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_sim9-install-pkg-noble-amd64
install_ci __upcoming__ gz_sim9-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_tools3-install-pkg-noble-amd64
install_ci __upcoming__ gz_tools3-install_bottle-homebrew-amd64
install_ci __upcoming__ gz_transport14-install-pkg-noble-amd64
Expand Down
Loading

0 comments on commit 8344708

Please sign in to comment.