Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose gzdev branch on PR / manual jobs #490

Open
chapulina opened this issue Jul 15, 2021 · 5 comments
Open

Choose gzdev branch on PR / manual jobs #490

chapulina opened this issue Jul 15, 2021 · 5 comments

Comments

@chapulina
Copy link
Contributor

It would be useful to be able to choose a gzdev branch on PR / manual jobs like this one:

https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/build?delay=0sec

This came up while testing a pre-release for this PR: gazebosim/gz-sim#661 (comment)

@scpeters
Copy link
Contributor

it would be convenient if we could add a label to a pull request in order to build with prerelease or nightly packages

@chapulina
Copy link
Contributor Author

You dream big! ✨

@scpeters
Copy link
Contributor

I have an alternative proposal in #564

@chapulina
Copy link
Contributor Author

I have an alternative proposal in #564

I think that works for PRs bumping versions, but that wouldn't cover the use case of PRs testing pre-releases. For example, to test gazebosim/gz-sim#869 against an ign-physics pre-release, we had to open a PR against gzdev like this: gazebo-tooling/gzdev#37 and then revert with another PR like this: gazebo-tooling/gzdev#39

@scpeters
Copy link
Contributor

For example, to test gazebosim/gz-sim#869 against an ign-physics pre-release, we had to open a PR against gzdev like this: gazebo-tooling/gzdev#37 and then revert with another PR like this: gazebo-tooling/gzdev#39

I think we could create a gzdev branch with matching name that uses prereleases, and it would use that for CI. We wouldn't even have to create a gzdev pull request. It does get more tricky to know which branches should be merged because CI could pass in a PR and then fail after merging if you don't merge the infrastructure branches properly. Overall, though, I think it would work for this case too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants