-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use matching branch in CI from infrastructure repositories #564
Comments
This was referenced Nov 19, 2021
A first attempt at this for |
scpeters
added a commit
that referenced
this issue
Nov 25, 2021
Part of #564. Signed-off-by: Steve Peters <[email protected]>
brew CI should be handled by #575 |
|
scpeters
added a commit
that referenced
this issue
Dec 3, 2021
Part of #564. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this issue
Dec 3, 2021
Part of #564. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this issue
Dec 3, 2021
* Part of #564. * Fix replacing ign-fuel-tools branch name with main Replace branch name before swapping - for _ in DEP_LIB. * Make source code pull request after metadata The source code PRs will fail without the metadata, so commit the metadata first. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this issue
Dec 4, 2021
Use in windows CI to try matching gazebodistro branch. Fixes #579. Part of #564. Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to gazebosim/gz-common
that referenced
this issue
Dec 30, 2021
Part of gazebo-tooling/release-tools#564 Signed-off-by: Steve Peters <[email protected]>
7 tasks
scpeters
added a commit
to gazebosim/gz-common
that referenced
this issue
Dec 30, 2021
Part of gazebo-tooling/release-tools#564 Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CI is challenging for PRs that bump version dependencies because they require changes to infrastructure repositories like the following:
In practice, we often merge the infrastructure PRs first to allow CI to work in the library PR then try to merge the library PR as quickly as possible because other pull requests will be broken. I think we could simplify this by changing our
-ci-pr_any-
builds to check if the library branch name matches a branch name in these infrastructure repositories and use the matching name if so. We could also consider requiring a special string in the branch name (likebranch_match
) to avoid false positives.The text was updated successfully, but these errors were encountered: