Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matching branch in CI from infrastructure repositories #564

Closed
scpeters opened this issue Nov 19, 2021 · 3 comments
Closed

Use matching branch in CI from infrastructure repositories #564

scpeters opened this issue Nov 19, 2021 · 3 comments

Comments

@scpeters
Copy link
Contributor

CI is challenging for PRs that bump version dependencies because they require changes to infrastructure repositories like the following:

In practice, we often merge the infrastructure PRs first to allow CI to work in the library PR then try to merge the library PR as quickly as possible because other pull requests will be broken. I think we could simplify this by changing our -ci-pr_any- builds to check if the library branch name matches a branch name in these infrastructure repositories and use the matching name if so. We could also consider requiring a special string in the branch name (like branch_match) to avoid false positives.

@scpeters
Copy link
Contributor Author

A first attempt at this for gzdev is in #572

scpeters added a commit that referenced this issue Nov 25, 2021
@scpeters
Copy link
Contributor Author

brew CI should be handled by #575

scpeters added a commit that referenced this issue Dec 3, 2021
scpeters added a commit that referenced this issue Dec 3, 2021
scpeters added a commit that referenced this issue Dec 3, 2021
* Part of #564.
* Fix replacing ign-fuel-tools branch name with main
  Replace branch name before swapping - for _ in DEP_LIB.
* Make source code pull request after metadata
  The source code PRs will fail without the metadata,
  so commit the metadata first.

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this issue Dec 4, 2021
Use in windows CI to try matching gazebodistro branch.

Fixes #579.
Part of #564.

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit to gazebosim/gz-common that referenced this issue Dec 30, 2021
scpeters added a commit to gazebosim/gz-common that referenced this issue Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant