Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches and doc for GzHarmonic ros_gz creation #1003

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 1, 2023

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although I don't understand why we need the replacement logic instead of putting all the gazebo keys (Garden and Harmonic) in one .yaml file.

@@ -55,6 +55,19 @@ package name.
- Usage: `$ rename-ros_gz-pkgs.bash <desired_gz_version> <space separted list of rosdistros to release>`
- Example: `$ rename-ros_gz-pkgs.bash garden humble`

The script supports to inject a custom RELEASE_REPO_URL that points to a bloom gbp
repository different than https://github.com/gazebo-release/ros_ign-release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an example right? The repo is not supposed to exist already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo exists and host humble metadata for Garden. See the tabel in line 30 in this same document.

Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero merged commit bea701a into master Oct 2, 2023
1 check passed
@j-rivero j-rivero deleted the jrivero/conflicting_ros_gz_garden_harmonic branch October 2, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants