Add support to report issue to ROS gz_*_vendor repositories in release.py #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
azeey
reviewed
Jun 3, 2024
release.py
Outdated
Comment on lines
561
to
575
| def create_issue_in_gz_vendor_repo(args, ros_distro): | ||
| gz_vendor_repo = get_vendor_github_repo(args.package) | ||
| title = f'Update version for {ros_distro} to the latest tag of {args.package}: {args.version}' | ||
| body = f'The {get_canonical_package_name(args.package)} repository tagged a new: {args.version} '\ | ||
| 'This repository needs to be updated accordingly for the branch {ros_distro}:\n'\ | ||
| ' * Sync to the new version in CMakelists.txt \n'\ | ||
| ' * Bump the patch version in package.xml \n'\ | ||
| ' * Run the release process for this ROS package' | ||
| _out, _err = create_issue_in_repo(gz_vendor_repo, title, body) | ||
| if _err: | ||
| print(' !! An error happened running the "gh issue" cmd. Do not run this script again.\n' | ||
| ' Please create the issue manually. The error reported was:\n' | ||
| f' {_err}') | ||
| sys.exit(1) | ||
| return _out |
There was a problem hiding this comment.
Is it possible to create a pull request instead? All we have to do is run https://github.com/gazebo-tooling/gz_vendor/blob/main/create_gz_vendor_pkg/create_vendor_package.py and give it the up-to-date package.xml from the upstream Gazebo library.
Signed-off-by: Jose Luis Rivero <[email protected]>
Moving to a new PR for the creation of automatically PRs for updating versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait to process #1148 first
This PR adds support in
release.pyto automatically create issues in the gz_*_vendor repositories when a new release for any gazebo libraries is being created:jenkins-scripts/dsl/tools/get_collections_from_package_and_version.pyin Include a script to obtain gazebo releases for a given library #1148 that is able to return Gazebo releases given a library a version. To known the vendor repository from a Gazebo releases the script uses a simple approach by now defining a map of gazebo-release <-> ros-distroROS_VENDOR = {'harmonic': 'rolling'}that assumes also that vendor repository branches are named in the same way than the ROS release names.ghtool https://cli.github.com/ . If the command is not present in the system, the release.py script will ask the user to create the issue manually.The PR also implements an output parsing for detecting if the ROS vendor commands are being processed correctly for a variety of options.