Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NEED_C11_COMPILER variable and simplify NEED_C17_COMPILER #648

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Remove NEED_C11_COMPILER variable and simplify NEED_C17_COMPILER #648

merged 6 commits into from
Feb 16, 2022

Conversation

j-rivero
Copy link
Contributor

This should stop problems with #639. Two main changes in the PR:

  • Remove NEED_C11_COMPILER since all our linux platforms implements the standard by default.
  • Reduce logic duplication for NEED_C17_COMPILER

Tested:

  • common4 build on Bionic, needs the custom compiler: Build Status
  • common4 build on Focal, don't use the custom compiler: Build Status

@j-rivero
Copy link
Contributor Author

Need to solve nightlies. Going to merge this one.

@j-rivero j-rivero merged commit d044dd6 into master Feb 16, 2022
@j-rivero j-rivero deleted the fix_gcc_version branch February 16, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-rivero