Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden : ign-cmake3 #686

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Bumps in garden : ign-cmake3 #686

merged 2 commits into from
Apr 8, 2022

Conversation

methylDragon
Copy link
Contributor

See #685

@methylDragon
Bumps in garden : ign-cmake3
6052e36 
Signed-off-by: methylDragon <[email protected]>
@chapulina
Copy link
Contributor

There are no PRs that have been merged into ign-cmake2 since the last nightly.

I think this PR could benefit being in a nightly in the coming days though:

So let's punt on merging this for now. I'll look into triggering ign-cmake3 nightlies manually.

@methylDragon
Copy link
Contributor Author

Nightlies were triggered, I think? https://build.osrfoundation.org/job/ign-cmake3-debbuilder/4/

@chapulina
Copy link
Contributor

Nightlies were triggered, I think? https://build.osrfoundation.org/job/ign-cmake3-debbuilder/4/

humm maybe by hand?

I think this PR could benefit being in a nightly in the coming days though:

I see @j-rivero is already planning a stable ign-cmake release for that PR:

So I think it's safe to say we're not relying on ign-cmake2 nightlies for that. I'll go ahead and merge this PR then.

@chapulina chapulina merged commit c876077 into master Apr 8, 2022
@chapulina chapulina deleted the ci_matching_branch/bump_garden_ign-cmake3 branch April 8, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina