Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign-tools doesn't depend on ign-cmake #691

Merged
merged 1 commit into from
Apr 8, 2022
Merged

ign-tools doesn't depend on ign-cmake #691

merged 1 commit into from
Apr 8, 2022

Conversation

chapulina
Copy link
Contributor

This was probably added back when we attempted to add ign-cmake as a dependency, and it wasn't reverted when we failed.

I noticed it because it's making ign-cmake2 and ign-cmake3 be installed side-by-side as we bump libraries in

@chapulina chapulina requested a review from j-rivero as a code owner April 8, 2022 00:32
methylDragon
methylDragon approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, ign-tools doesn't have a ign-cmake reference in its CMakeLists.txt. I don't expect this to break anything else since it's an extraneous dependency at this point...

@j-rivero j-rivero merged commit be1b52b into master Apr 8, 2022
@j-rivero j-rivero deleted the chapulina/tools_cmake branch April 8, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@scpeters scpeters scpeters approved these changes

@methylDragon methylDragon methylDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapulina @j-rivero @scpeters @methylDragon