-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake macro to find the assimp library #278
Conversation
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me locally on Linux. On Focal it detects a version below 5.2.0 and on Jammy it's above. We could try out macOS and Windows with some custom branches before merging, but since this change is quite isolated, we're close to feature freeze, and it targets an unstable branch, I think it's worth merging it and we can iterate on future PRs if needed.
Tested locally, LGTM. |
🎉 New feature
Summary
This PR adds support to
gz_find_package
for finding the assimp package including the ability to specify a version.Test it
It can be tested with the upstream PR in gz-common, try to build it with and without this branch and check that it fails without.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.