Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FindGzAssimp to use find_package #291

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Conversation

luca-della-vedova
Copy link
Member

🦟 Bug fix

Summary

The previous implementation of FindGzAssimp had issues on Windows, specifically on Windows it seems that it is necessary to use find_package instead of pkg-config, i.e. vcpkg prints the following:

The package assimp provides CMake targets:

    find_package(assimp CONFIG REQUIRED)
    target_link_libraries(main PRIVATE assimp::assimp)

but using find_package sets global variables that break downstream users that reimplement their own version of FindAssimp such as dartsim.

For these reasons the implementation now uses find_package but clears the cache from the assimp variables and only uses the GzAssimp namespaced variables. Downstream behavior is now unchanged.

Tested with the gz-common PR to make sure CI is ✔️

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 29, 2022
@chapulina chapulina added the bug Something isn't working label Jul 29, 2022
@chapulina chapulina enabled auto-merge (squash) July 29, 2022 18:15
@chapulina chapulina disabled auto-merge July 29, 2022 18:17
@chapulina
Copy link
Contributor

Merging without the Windows CI to clear up the build farm. Windows CI on this repo shouldn't be catching any issues with this PR anyway.

@chapulina chapulina merged commit 3b2bc54 into main Jul 29, 2022
@chapulina chapulina deleted the luca/assimp_find_package branch July 29, 2022 18:18
@chapulina
Copy link
Contributor

Nightlies:

  • Focal Build Status
  • Jammy Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants