Change FindGzAssimp to use find_package #291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The previous implementation of FindGzAssimp had issues on Windows, specifically on Windows it seems that it is necessary to use
find_package
instead ofpkg-config
, i.e. vcpkg prints the following:but using
find_package
sets global variables that break downstream users that reimplement their own version ofFindAssimp
such as dartsim.For these reasons the implementation now uses find_package but clears the cache from the
assimp
variables and only uses theGzAssimp
namespaced variables. Downstream behavior is now unchanged.Tested with the gz-common PR to make sure CI is ✔️
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.