Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative paths for pkg-config install directory #443

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 16, 2024

🦟 Bug fix

Summary

This makes it so that all of our libraries use relative install paths and work well in build systems that don't set CMAKE_INSTALL_PREFIX.

gz_cmake_vendor is patched with this so it can build on the ROS buildfarm (see gazebo-release/gz_cmake_vendor#4).

With this patch, running cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -P cmake_install.cmake from the build directory of any of our libraries will succeed showing that no absolute install destination is used.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 16, 2024
@azeey azeey added bug Something isn't working beta Targeting beta release of upcoming collection labels Aug 16, 2024
@azeey azeey requested a review from iche033 August 16, 2024 21:14
@azeey azeey merged commit ec85d5f into gazebosim:main Aug 16, 2024
10 checks passed
@azeey azeey deleted the pkg_config_relative_path branch August 16, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants