-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable long-running buildsystem tests by default #97
Conversation
4522a3f
to
b08a2a6
Compare
Note to reviewers, the action PR needs to land first, and then I will correct the branches in the workflow file and reduce it to single build with the full build invocation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passes with the action's master branch.
Also we need to look into what happened to the Jenkins builds.
Finally we should consider enabling these tests on Jenkins.
This looks like it built on a |
9d851e6
to
175be6d
Compare
Oh I just saw that this PR builds on top of #96 . See my comment on that PR for why we can't remove the pipelines file just yet. |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Louise Poubel <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
175be6d
to
2a11e68
Compare
Rebased and force-pushed. |
Unless we get the flag turned on in jenkins, I would expect the other CI jobs to fail because there is no test output. |
Ah, this will only impact Windows, because we have a test available in UNIX platforms. |
for Ubuntu, I think we could set the |
here's the cmake invocation line on windows: https://github.com/ignition-tooling/release-tools/blob/master/jenkins-scripts/lib/generic-default-devel-windows.bat#L85 |
Since this passes everything but Windows, I'm going to merge. Windows CI will go green when this lands: gazebo-tooling/release-tools#210 |
I'd prefer to wait for the release-tools PR to land before merging this |
In retrospect, I can't merge it because of the branch protection, so you'll get your wish. |
I've cherry-picked these commits onto |
Signed-off-by: Steve Peters <[email protected]>
Can you backport to |
Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
* Part of gazebo-tooling/release-tools#203 * Disable long-running buildsystem tests by default (#97) (#100) * backport triage and labeler Signed-off-by: Steve Peters <[email protected]> Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
From #92, this disables several tests that take a while to run and aren't correctly detected by CMake's change-detection. This adds a new option
BUILDSYSTEM_TESTING
, which will re-enable these tests when true, and enables it in pipelines.Tested locally with:
Depends on gazebo-tooling/action-gz-ci#9