Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTEGRATION_video_encoder fails on arm64, armhf debbuilds #180

Closed
scpeters opened this issue Mar 9, 2021 · 1 comment · Fixed by #183
Closed

INTEGRATION_video_encoder fails on arm64, armhf debbuilds #180

scpeters opened this issue Mar 9, 2021 · 1 comment · Fixed by #183
Labels
bug Something isn't working tests Broken or missing tests / testing infra

Comments

@scpeters
Copy link
Member

scpeters commented Mar 9, 2021

Environment

  • OS Version: Ubuntu 18.04, 20.04 and Debian Buster
  • Source or binary build?

debbuild of 3.11.0

Description

The following tests FAILED:
	 43 - INTEGRATION_video_encoder (Failed)
Errors while running CTest
43/93 Test #43: INTEGRATION_video_encoder ...................***Failed    4.55 sec
Running main() from /var/lib/jenkins/workspace/ign-common3-debbuilder/build/ignition-common-3.11.0/test/gtest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EncoderDecoderTest
[ RUN      ] EncoderDecoderTest.DecodeEncodeDecode
�[1;32m[Msg] �[0m�[1;32mCompatible SW encoder: �[0m�[1;32mlibx264�[0m�[1;32m�[0m
�[1;32m[Msg] �[0m�[1;32mUsing encoder �[0m�[1;32mlibx264�[0m�[1;32m�[0m
�[1;32m[Msg] �[0m�[1;32mFPS: �[0m�[1;32m42.2372�[0m�[1;32m�[0m
�[1;32m[Msg] �[0m�[1;32mFPS: �[0m�[1;32m40.6361�[0m�[1;32m�[0m
/var/lib/jenkins/workspace/ign-common3-debbuilder/build/ignition-common-3.11.0/test/integration/video_encoder.cc:135: Failure
The difference between avgIntensity2 and avgIntensity is 1.8609066972724975, which exceeds 1.0, where
avgIntensity2 evaluates to 222.84679089026915,
avgIntensity evaluates to 224.70769758754165, and
1.0 evaluates to 1.
[  FAILED  ] EncoderDecoderTest.DecodeEncodeDecode (3003 ms)
[----------] 1 test from EncoderDecoderTest (3004 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (3008 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] EncoderDecoderTest.DecodeEncodeDecode

 1 FAILED TEST

Steps to reproduce

  1. Build on arm64 or armhf system
  2. Run ctest

Output

@scpeters scpeters added the bug Something isn't working label Mar 9, 2021
@chapulina chapulina added the tests Broken or missing tests / testing infra label Mar 9, 2021
@chapulina chapulina mentioned this issue Mar 9, 2021
7 tasks
@peci1
Copy link
Contributor

peci1 commented Mar 9, 2021

Hmm... I wonder if doubling the intensity limit would be a non-flaky solution? The intensity tests were added mainly to prevent cases when the encoded video is completely wrong (all black, greenish film, stripes caused by wrong memory alignment)... so I think even raising the limit to 5 or 10 is okay (if I remember correctly, intensity here goes 0...255).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants