Relax expectation so encoder test passes on ARM #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
github-actions
bot
added
🏰 citadel
|
Thanks for the fix. As I commented at #180 , if you agree with setting the limit to 2.0, I'm okay with it ;) |
peci1
approved these changes
Mar 9, 2021
|
I just wonder this wasn't discovered by nightly builds... or are they done just for x86? |
Codecov Report
@@ Coverage Diff @@
## ign-common3 #183 +/- ##
============================================
Coverage 75.39% 75.39%
============================================
Files 72 72
Lines 10249 10249
============================================
Hits 7727 7727
Misses 2522 2522 Continue to review full report at Codecov.
|
Nice, I hadn't even seen that!
Yup, we've only been releasing nightlies for amd64 |
chapulina
added a commit
that referenced
this pull request
Mar 19, 2021
* 🎈 3.11.0 (#178) Signed-off-by: Louise Poubel <[email protected]> * Relax expectation so encoder test passes on ARM (#183) Signed-off-by: Louise Poubel <[email protected]> * Revert "Associate library materials effect with meshes (#151)" (#182) This reverts commit 89b1157. Signed-off-by: Louise Poubel <[email protected]> * 🎈 3.11.1 (#184) Signed-off-by: Louise Poubel <[email protected]> * Master branch updates (#179) Part of gazebo-tooling/release-tools#416 Signed-off-by: Louise Poubel <[email protected]> * Remove use of _SOURCE and _BINARY dirs in tests (#158) Test cleanup: Merges test/util.hh and test_config.h into a single file (fixes include path issues) Adds fixtures for retrieving test data from test/data folder Moves testing utilities into ignition::common::testing Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #180
Summary
The difference on that expectation for all ARM builds (arm64 and armhf) were exactly 1.86, so I think relaxing the tolerance to 2.0 should fix them.
I haven't looked closely enough at #125, but quickly looking at the test this seems like a reasonable solution to me.
CC @peci1
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge