-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax expectation so encoder test passes on ARM #183
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Thanks for the fix. As I commented at #180 , if you agree with setting the limit to 2.0, I'm okay with it ;) |
I just wonder this wasn't discovered by nightly builds... or are they done just for x86? |
Codecov Report
@@ Coverage Diff @@
## ign-common3 #183 +/- ##
============================================
Coverage 75.39% 75.39%
============================================
Files 72 72
Lines 10249 10249
============================================
Hits 7727 7727
Misses 2522 2522 Continue to review full report at Codecov.
|
Nice, I hadn't even seen that!
Yup, we've only been releasing nightlies for amd64 |
* 🎈 3.11.0 (#178) Signed-off-by: Louise Poubel <[email protected]> * Relax expectation so encoder test passes on ARM (#183) Signed-off-by: Louise Poubel <[email protected]> * Revert "Associate library materials effect with meshes (#151)" (#182) This reverts commit 89b1157. Signed-off-by: Louise Poubel <[email protected]> * 🎈 3.11.1 (#184) Signed-off-by: Louise Poubel <[email protected]> * Master branch updates (#179) Part of gazebo-tooling/release-tools#416 Signed-off-by: Louise Poubel <[email protected]> * Remove use of _SOURCE and _BINARY dirs in tests (#158) Test cleanup: Merges test/util.hh and test_config.h into a single file (fixes include path issues) Adds fixtures for retrieving test data from test/data folder Moves testing utilities into ignition::common::testing Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
🦟 Bug fix
Fixes #180
Summary
The difference on that expectation for all ARM builds (arm64 and armhf) were exactly 1.86, so I think relaxing the tolerance to 2.0 should fix them.
I haven't looked closely enough at #125, but quickly looking at the test this seems like a reasonable solution to me.
CC @peci1
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge