-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #188: Fix crash when using BVH animations #199
Backport #188: Fix crash when using BVH animations #199
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-common3 #199 +/- ##
===============================================
- Coverage 75.20% 75.00% -0.20%
===============================================
Files 73 72 -1
Lines 10307 10290 -17
===============================================
- Hits 7751 7718 -33
- Misses 2556 2572 +16
Continue to review full report at Codecov.
|
I tried testing this by running
I'm not sure why this is happening. I'll need to look into it some more, unless someone else knows what's going on here? |
@osrf-jenkins retest this please |
I spent some time debugging the crashes on Citadel but the more I dig, the uglier it gets. I have added some safety checks on the following 2 branches: My favorite one is the I suspect that the best course of action right now should be to revert #136, because as the documentation says, the What's best, a memory leak, or a segfault? ⚖️ |
d88af6f
to
a3983b6
Compare
@chapulina I believe I may have fixed the issue 🤞 since More information about this can be found in #136 (comment). |
/// \brief Assignment operator | ||
/// \param[in] _other The new SkeletonAnimation | ||
/// \return A reference to this instance | ||
public: SkeletonAnimation &operator=(const SkeletonAnimation &_other); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function should not be merged forward to ign-common4 right? Can you add a note as a reminder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added: af8b84a
Let me know if there's a better way/format of adding a note like this. I don't think it should be a TODO
since nothing really needs to be "done", and I also assume it shouldn't be a doxygen comment since this isn't relevant for user documentation (it's more of just an internal developer note).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiice! It works for me with the assignment operator 😃
Signed-off-by: Ashton Larkin <[email protected]>
af8b84a
to
ee6fe52
Compare
Signed-off-by: Ashton Larkin [email protected]
🦟 Bug fix
Related to gazebosim/gz-sim#647
Summary
This is a backport of #188. Once this is merged, we should no longer see actors crash at launch (the
ign-common3
branch applies to both Citadel and Dome).To test this, run
ign gazebo -r actor.sdf
and make sure no crash occurs.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge