Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 to 4 11302020 #137

Merged
merged 3 commits into from
Nov 30, 2020
Merged

3 to 4 11302020 #137

merged 3 commits into from
Nov 30, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Nov 30, 2020

No description provided.

nkoenig and others added 3 commits November 30, 2020 09:57
)

* Use lowercase resource and owner names when storing assets on disk

Signed-off-by: Nate Koenig <[email protected]>

* Remove added diff text from merge

Signed-off-by: John Shepherd <[email protected]>

* change model version in test back

Signed-off-by: John Shepherd <[email protected]>

* Fix test

Signed-off-by: Nate Koenig <[email protected]>

* Fix windows

Signed-off-by: Nate Koenig <[email protected]>

* Fix more windows tests

Signed-off-by: Nate Koenig <[email protected]>

* Testing another windows fix

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: John Shepherd <[email protected]>
* Prepare for 3.5.0 release

Signed-off-by: Nate Koenig <[email protected]>

* Update Changelog.md

Co-authored-by: Louise Poubel <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #137 (2f090d6) into ign-fuel-tools4 (ad1967a) will increase coverage by 1.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #137      +/-   ##
===================================================
+ Coverage            77.12%   78.14%   +1.02%     
===================================================
  Files                   19       19              
  Lines                 2535     2727     +192     
===================================================
+ Hits                  1955     2131     +176     
- Misses                 580      596      +16     
Impacted Files Coverage Δ
src/ModelIdentifier.cc 92.35% <100.00%> (+0.09%) ⬆️
src/WorldIdentifier.cc 100.00% <100.00%> (ø)
src/FuelClient.cc 73.63% <0.00%> (+5.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1967a...2f090d6. Read the comment docs.

@chapulina chapulina merged commit 56a0bee into ign-fuel-tools4 Nov 30, 2020
@chapulina chapulina deleted the 3_to_4_11302020 branch November 30, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants