Fix light map URI in materials #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools5 #146 +/- ##
===================================================
- Coverage 78.00% 77.99% -0.02%
===================================================
Files 19 19
Lines 2601 2604 +3
===================================================
+ Hits 2029 2031 +2
- Misses 572 573 +1
Continue to review full report at Codecov.
|
chapulina
approved these changes
Dec 10, 2020
nkoenig
approved these changes
Dec 16, 2020
|
Windows CI seems to be in a tough place right now. Merging without it. |
nkoenig
added a commit
that referenced
this pull request
Dec 23, 2020
* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <[email protected]> * Remove added diff text from merge Signed-off-by: John Shepherd <[email protected]> * change model version in test back Signed-off-by: John Shepherd <[email protected]> * Fix test Signed-off-by: Nate Koenig <[email protected]> * Fix windows Signed-off-by: Nate Koenig <[email protected]> * Fix more windows tests Signed-off-by: Nate Koenig <[email protected]> * Testing another windows fix Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <[email protected]> * Update Changelog.md Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Download model dependencies (#123) Signed-off-by: John Shepherd <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Set keep alive on (#141) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Support editing/patching model files (#140) * Support editing/patching model files Signed-off-by: Nate Koenig <[email protected]> * Added documentation Signed-off-by: Nate Koenig <[email protected]> * Set keep alive on Signed-off-by: Nate Koenig <[email protected]> * Documentation and tests Signed-off-by: Nate Koenig <[email protected]> * One more test and exit catch missing -u Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Prepare for 5.1.0 release (#145) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Fix light map URI (#146) Signed-off-by: Ian Chen <[email protected]> * Bump to 5.1.1 (#147) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we can convert
model://<model_name>/<path_to_texture>.pngto absolute path on local disk.related pull request: gazebosim/gz-sim#471
Signed-off-by: Ian Chen [email protected]