Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 ➡️ 6 #169

Merged
merged 11 commits into from
Mar 9, 2021
Merged

5 ➡️ 6 #169

merged 11 commits into from
Mar 9, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-fuel-tools5 to main

Branch comparison: main...ign-fuel-tools5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

chapulina and others added 11 commits December 23, 2020 09:31
Also explicitly depend on ign-math6

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: John Shepherd <[email protected]>

Co-authored-by: Mabel Zhang <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Jose Luis Rivero <[email protected]>
* Included private-token to config.yaml

Signed-off-by: ahcorde <[email protected]>

* make linters happy

Signed-off-by: ahcorde <[email protected]>

* Added feedback

Signed-off-by: ahcorde <[email protected]>

* Added documentation

Signed-off-by: ahcorde <[email protected]>

* Added feedback

Signed-off-by: ahcorde <[email protected]>

* make linters happy

Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from nkoenig as a code owner March 4, 2021 19:43
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #169 (042d1c2) into main (dddb1ef) will decrease coverage by 0.46%.
The diff coverage is 58.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   77.93%   77.47%   -0.47%     
==========================================
  Files          20       20              
  Lines        2619     2672      +53     
==========================================
+ Hits         2041     2070      +29     
- Misses        578      602      +24     
Impacted Files Coverage Δ
src/ClientConfig.cc 84.75% <47.05%> (-3.23%) ⬇️
src/LocalCache.cc 79.47% <62.50%> (-0.53%) ⬇️
src/FuelClient.cc 69.67% <63.15%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dddb1ef...042d1c2. Read the comment docs.

@chapulina chapulina merged commit 2d15118 into main Mar 9, 2021
@chapulina chapulina deleted the chapulina/5_to_6 branch March 9, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants