Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows warning for exception c++ code #212

Closed
wants to merge 1 commit into from

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Oct 25, 2021

Signed-off-by: Jorge Perez [email protected]

🦟 Bug fix

Fixes #211

Summary

Include the missing flag for Windows builds. This will be forward ported up to ign-fuel-tools-7

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Oct 25, 2021
@Blast545 Blast545 self-assigned this Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #212 (8250612) into ign-fuel-tools4 (d078bd0) will not change coverage.
The diff coverage is n/a.

❗ Current head 8250612 differs from pull request most recent head 91eed29. Consider uploading reports for the commit 91eed29 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-fuel-tools4     #212   +/-   ##
================================================
  Coverage            78.13%   78.13%           
================================================
  Files                   19       19           
  Lines                 2643     2643           
================================================
  Hits                  2065     2065           
  Misses                 578      578           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d078bd0...91eed29. Read the comment docs.

@azeey
Copy link
Contributor

azeey commented Oct 26, 2021

I think the warning is coming from ign-tools, not from ign-fuel-tools. Should hopefully be fixed by gazebosim/gz-tools#68

@Blast545
Copy link
Contributor Author

@azeey The error comes from ign-tools indeed, but I am not sure setting the variable there would fix the issue here. If the other PR removes the warnings I'd close this PR, I'd take a look after its merged.

@azeey
Copy link
Contributor

azeey commented Oct 26, 2021

@azeey The error comes from ign-tools indeed, but I am not sure setting the variable there would fix the issue here. If the other PR removes the warnings I'd close this PR, I'd take a look after its merged.

It's merged. Can you give it a try?

@Blast545
Copy link
Contributor Author

@azeey Sure! I'll just retrigger a CI for ign-fuel_tools4:

  • ign-fuel_tools4 Build Status

@Blast545
Copy link
Contributor Author

It was fixed, thank you! @azeey !

@Blast545 Blast545 closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants