Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-fuel-tools #272

Merged
merged 2 commits into from
Jul 13, 2022
Merged

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-fuel-tools #272

merged 2 commits into from
Jul 13, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jul 12, 2022
Closed
32 tasks
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 12, 2022
@chapulina chapulina self-requested a review July 12, 2022 18:22
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 12, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jul 12, 2022
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 42c81ac to 4520a5e Compare July 12, 2022 20:54
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #272 (ddd6a2f) into main (9f719f7) will not change coverage.
The diff coverage is n/a.

❗ Current head ddd6a2f differs from pull request most recent head 0776c20. Consider uploading reports for the commit 0776c20 to get more accurate results

@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         2110     2110           
  Misses        753      753
Impacted Files Coverage Δ
src/FuelClient.cc 67.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f719f7...0776c20. Read the comment docs.

@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 4520a5e to ddd6a2f Compare July 13, 2022 00:17
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jul 13, 2022
chapulina
chapulina approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

src/cmd/CMakeLists.txt Outdated
endif()

set(IGN_LIBRARY_NAME ${GZ_LIBRARY_NAME}) # TODO(CH3): Deprecated. Remove on tock.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is only used by cmdfuel.rb.in, so we can hard-tock it

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from ddd6a2f to bbbba31 Compare July 13, 2022 07:56
@methylDragon
Move gz.in (#272)
150080f 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Partial source and CMake migration (#272)
3147718 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from bbbba31 to 3147718 Compare July 13, 2022 07:56
methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Partial source and CMake migration (#272)
d0efe10 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 3147718 to d0efe10 Compare July 13, 2022 07:58
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from d0efe10 to 0776c20 Compare July 13, 2022 08:04
@methylDragon methylDragon merged commit f58d254 into main Jul 13, 2022
@methylDragon methylDragon deleted the ci_matching_branch/file_and_source_migration branch July 13, 2022 08:54
methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Move gz.in (#272)
147ba03 
Signed-off-by: methylDragon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina