Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 Print Qt plugin debug messages on Actions #211

Closed
wants to merge 1 commit into from

Conversation

chapulina
Copy link
Contributor

Summary

This should make test runs in GitHub actions more verbose. I hope the extra information will help decipher what's happening on #58.

There's a change the new messages pollute the test results, because it outputs a lot of stuff. Considering that this is being enabled only for Actions, but not on Jenkins, I think it's not too bad.

Test it

See GitHub actions output.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

https://github.com/osrf/buildfarmer/issues/181

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #211 (8acb9da) into ign-gui3 (064f815) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #211   +/-   ##
=========================================
  Coverage     59.03%   59.03%           
=========================================
  Files            23       23           
  Lines          2739     2739           
=========================================
  Hits           1617     1617           
  Misses         1122     1122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064f815...8acb9da. Read the comment docs.

@chapulina
Copy link
Contributor Author

Ha, interestingly, the flaky failure happened and that test case didn't have any extra debug output 😬

2021-04-22T00:45:17.5540977Z [ RUN      ] HelpersTest.worldNames
2021-04-22T00:45:17.5542514Z �[1;31m[GUI] [Err] [Application.cc:653] �[0m�[1;31m[QT] This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Apr 22, 2021
@chapulina
Copy link
Contributor Author

I'll close this because it adds clutter and doesn't shed a light into the flaky tests.

@chapulina chapulina closed this Apr 23, 2021
@chapulina chapulina deleted the chapulina/3/debug branch August 31, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant