Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport GridConfig improvements to Citadel's Grid3D #363

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Part of gazebosim/gz-sim#1254

Summary

#324 made multiple improvements to GridConfig and Grid3D, and also consolidated them into the same plugin. That went into Fortress.

On Citadel, GridConfig is on ign-gazebo, while Grid3D is on ign-gui (GridConfig was moved to ign-gui in #236 ). So what this PR does is copy the GridConfig code from ign-gui6 into ign-gui3's Grid3D.

Test it

Load the Grid3D plugin from the menu on ign-gazebo, for example.

image

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Mar 3, 2022
@chapulina chapulina requested a review from jennuine as a code owner March 3, 2022 03:36
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #363 (ce4a9a4) into ign-gui3 (a6afb94) will decrease coverage by 1.83%.
The diff coverage is 6.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui3     #363      +/-   ##
============================================
- Coverage     67.79%   65.96%   -1.84%     
============================================
  Files            28       29       +1     
  Lines          3118     3191      +73     
============================================
- Hits           2114     2105       -9     
- Misses         1004     1086      +82     
Impacted Files Coverage Δ
src/plugins/grid_3d/Grid3D.hh 100.00% <ø> (ø)
src/plugins/grid_3d/Grid3D.cc 10.58% <6.33%> (-17.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6afb94...ce4a9a4. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 9fa41b6 into ign-gui3 Mar 3, 2022
@chapulina chapulina deleted the chapulina/3/backport_324 branch March 3, 2022 19:06
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants