Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate plugins that were empty #366

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Populate plugins that were previously empty so that users aren't too confused when inserting them from the menu.

image

CameraTracking

Besides displaying message:

  • Add top-level plugin docs

InteractiveViewControl

Besides displaying message:

  • Add plugin title

MarkerManager

Besides displaying message:

  • Make sure stats_topic works even when there's no _pluginElem
  • Update docs

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Mar 4, 2022
@chapulina chapulina requested a review from jennuine as a code owner March 4, 2022 02:53
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 4, 2022
Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #366 (678065e) into ign-gui6 (70255cc) will increase coverage by 0.04%.
The diff coverage is 63.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui6     #366      +/-   ##
============================================
+ Coverage     65.38%   65.43%   +0.04%     
============================================
  Files            39       39              
  Lines          5117     5123       +6     
============================================
+ Hits           3346     3352       +6     
  Misses         1771     1771              
Impacted Files Coverage Δ
src/plugins/marker_manager/MarkerManager.cc 60.51% <60.71%> (+0.51%) ⬆️
...interactive_view_control/InteractiveViewControl.cc 17.88% <100.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70255cc...678065e. Read the comment docs.

@chapulina chapulina enabled auto-merge (squash) March 4, 2022 16:26
@chapulina chapulina merged commit ce4c368 into ign-gui6 Mar 4, 2022
@chapulina chapulina deleted the chapulina/6/empty_plugins branch March 4, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants