Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ign-rendering's screenToScene functions #372

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Garden is crashing when there are points in the scene, and the user hovers or clicks on the 3D scene.

The changes in this PR fixes the hover, but the clicks are only fixed by

Since the TODO was there since Fortress, I targeted this PR at ign-gui6 and we can merge forward afterwards.

Test it

Load some Gazebo world and select, right-click on models, orbit the scene... The clicks should be in the right place.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added bug Something isn't working MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv labels Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #372 (c87c5c7) into ign-gui6 (dc268fe) will increase coverage by 0.18%.
The diff coverage is 67.42%.

@@             Coverage Diff              @@
##           ign-gui6     #372      +/-   ##
============================================
+ Coverage     65.40%   65.59%   +0.18%     
============================================
  Files            39       39              
  Lines          5079     5139      +60     
============================================
+ Hits           3322     3371      +49     
- Misses         1757     1768      +11     
Impacted Files Coverage Δ
src/Application.cc 85.35% <33.33%> (-0.45%) ⬇️
src/plugins/marker_manager/MarkerManager.cc 60.51% <60.71%> (+0.51%) ⬆️
src/plugins/minimal_scene/MinimalScene.cc 64.20% <66.66%> (+1.22%) ⬆️
...s/transport_scene_manager/TransportSceneManager.cc 53.97% <75.75%> (+1.68%) ⬆️
...interactive_view_control/InteractiveViewControl.cc 17.88% <100.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d327f6...c87c5c7. Read the comment docs.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 16, 2022
@chapulina chapulina merged commit ec910ed into ign-gui6 Mar 16, 2022
@chapulina chapulina deleted the chapulina/6/screenToScene branch March 16, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants