Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden : ign-gui7 #385

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Bumps in garden : ign-gui7 #385

merged 4 commits into from
Apr 14, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon
Bumps in garden : ign-gui7
677a20c 
Signed-off-by: methylDragon <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 13, 2022
chapulina
chapulina approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor greedy match. LGTM otherwise, once it has 🟢 CI

src/plugins/world_control/WorldControl.cc Outdated Show resolved Hide resolved
@chapulina
Copy link
Contributor

The new test failures are caused by a bad combination of ign-cmake2 and ign-cmake3 and their utilities package. I'm going to merge this as is because:

  • We have various merged and open PRs to get rid of utilities
  • The next wave of bumps should remove the double ign-cmake2 and ign-cmake3

Let's not block on this, merging!

@chapulina chapulina merged commit 47bddfc into main Apr 14, 2022
@chapulina chapulina deleted the ci_matching_branch/bump_garden_ign-gui7 branch April 14, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina