ign -> gz Header Migration : gz-gui #395

methylDragon · 2022-05-06T22:16:09Z

Signed-off-by: methylDragon <[email protected]>

chapulina · 2022-05-09T19:12:35Z

src/plugins/CMakeLists.txt

+    set(gz_gui_add_library_skip_parsing true)
+    gz_gui_add_library(${library_name})
+endfunction()
+function(gz_gui_add_library library_name)


Thanks for going through the trouble here, but I believe this function is not exposed to downstream users. It's very specific to adding an official plugin to gz-gui itself.

No longer tick-tocked in bff9d86

All the uses will need to be updated as well, CI is failing with

CMake Error at src/plugins/camera_tracking/CMakeLists.txt:1 (ign_gui_add_plugin): Unknown CMake command "ign_gui_add_plugin".

chapulina · 2022-05-09T22:12:19Z

include/gz/gui/Application.hh

+      ///
+      /// 1. Paths given by the environment variable
+      /// 2. Paths added by calling addPluginPath
+      /// 3. Path ~/.gz/gui/plugins


Note to self that the implementation hasn't been updated to use ~/.gz yet

include/gz/gui/resources.qrc

Signed-off-by: methylDragon <[email protected]>

codecov · 2022-05-11T12:25:09Z

Codecov Report

❗ No coverage uploaded for pull request base (main@bdbaaac). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f9a6933 differs from pull request most recent head 589074b. Consider uploading reports for the commit 589074b to get more accurate results

@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage        ?   30.03%           
=======================================
  Files           ?       43           
  Lines           ?     1888           
  Branches        ?        0           
=======================================
  Hits            ?      567           
  Misses          ?     1321           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbaaac...589074b. Read the comment docs.

chapulina

LGTM as long as we don't get any unexpected test failures. This package has lots of flaky tests, I'll make another comment once all CI is back.

Signed-off-by: methylDragon <[email protected]>

chapulina

CI looks good too, 🚢 it!

Signed-off-by: methylDragon <[email protected]>

… QML - Adapt the GammaAdjust element from QtGraphicalEffects to work with Metal - Add shaders from Qt - Create a Vulkan supported version of the fragment shader - Generate a shader pack using qsb - Refactor gamma adjustment QML - Move to own QML file and locate with ignition/gui/qml - Move shaders to a private subfolder - Update resources.qrc - Replace import QtGraphicalEffects 1.0 with import "qrc:/qml" Signed-off-by: Rhys Mainwaring <[email protected]> Move header files with git mv (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Create redirection aliases (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Migrate sources in src, test, examples, and include (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Migrate CMake files (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Update name and logo on UI, examples and API docs (gazebosim#398) Signed-off-by: Louise Poubel <[email protected]>

methylDragon requested review from chapulina and jennuine as code owners May 6, 2022 22:16

github-actions bot added the 🌱 garden Ignition Garden label May 6, 2022

methylDragon marked this pull request as draft May 6, 2022 22:16

methylDragon mentioned this pull request May 6, 2022

C++ namespaces, directories and header guards from ignition to gz gazebo-tooling/release-tools#711

Closed

methylDragon force-pushed the header_migration branch 2 times, most recently from 5a7e885 to b2212f2 Compare May 7, 2022 00:45

methylDragon marked this pull request as ready for review May 7, 2022 00:47

Move header files with git mv (#395)

642813f

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 7, 2022

Create redirection aliases (#395)

b49b200

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 7, 2022

Migrate sources in src, test, examples, and include (#395)

7778962

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 7, 2022

Migrate CMake files (#395)

2480ba6

Signed-off-by: methylDragon <[email protected]>

methylDragon force-pushed the header_migration branch from b2212f2 to 2480ba6 Compare May 7, 2022 01:21

chapulina added the needs upstream release Blocked by a release of an upstream library label May 9, 2022

chapulina suggested changes May 9, 2022

View reviewed changes

methylDragon added a commit that referenced this pull request May 11, 2022

Migrate sources in src, test, examples, and include (#395)

58141d7

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 11, 2022

Migrate CMake files (#395)

c94d042

Signed-off-by: methylDragon <[email protected]>

methylDragon force-pushed the header_migration branch from 3208547 to c94d042 Compare May 11, 2022 10:39

methylDragon added a commit that referenced this pull request May 11, 2022

Migrate sources in src, test, examples, and include (#395)

10b7216

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 11, 2022

Migrate CMake files (#395)

336121a

Signed-off-by: methylDragon <[email protected]>

methylDragon force-pushed the header_migration branch from c94d042 to 336121a Compare May 11, 2022 10:56

methylDragon added a commit that referenced this pull request May 11, 2022

Migrate sources in src, test, examples, and include (#395)

f72bc5b

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 11, 2022

Migrate CMake files (#395)

199de21

Signed-off-by: methylDragon <[email protected]>

methylDragon force-pushed the header_migration branch from 336121a to 199de21 Compare May 11, 2022 11:08

methylDragon added a commit that referenced this pull request May 11, 2022

Migrate sources in src, test, examples, and include (#395)

f224600

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 11, 2022

Migrate CMake files (#395)

ca4e181

Signed-off-by: methylDragon <[email protected]>

methylDragon force-pushed the header_migration branch from 199de21 to ca4e181 Compare May 11, 2022 12:09

chapulina added ign to gz Renaming Ignition to Gazebo and removed needs upstream release Blocked by a release of an upstream library labels May 11, 2022

chapulina approved these changes May 11, 2022

View reviewed changes

methylDragon added 2 commits May 12, 2022 14:59

Create redirection aliases (#395)

d2caef8

Signed-off-by: methylDragon <[email protected]>

Migrate sources in src, test, examples, and include (#395)

d9f235f

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 12, 2022

Migrate CMake files (#395)

bff9d86

Signed-off-by: methylDragon <[email protected]>

methylDragon force-pushed the header_migration branch from d923324 to bff9d86 Compare May 12, 2022 21:59

Migrate CMake files (#395)

589074b

Signed-off-by: methylDragon <[email protected]>

methylDragon force-pushed the header_migration branch from bff9d86 to 589074b Compare May 13, 2022 00:03

chapulina approved these changes May 14, 2022

View reviewed changes

methylDragon merged commit 01a0753 into main May 14, 2022

methylDragon deleted the header_migration branch May 14, 2022 01:36

methylDragon added a commit that referenced this pull request May 14, 2022

Move header files with git mv (#395)

bf5ee8c

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 14, 2022

Create redirection aliases (#395)

2bf0f0b

Signed-off-by: methylDragon <[email protected]>

methylDragon added a commit that referenced this pull request May 14, 2022

Migrate sources in src, test, examples, and include (#395)

3edd6d1

Signed-off-by: methylDragon <[email protected]>

chapulina mentioned this pull request Aug 1, 2022

[ign to gz] Deduplicate QML files #449

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ign -> gz Header Migration : gz-gui #395

ign -> gz Header Migration : gz-gui #395

methylDragon commented May 6, 2022

chapulina May 9, 2022

methylDragon May 12, 2022

chapulina May 12, 2022

chapulina May 9, 2022

codecov bot commented May 11, 2022 •

edited

Loading

chapulina left a comment

chapulina left a comment

ign -> gz Header Migration : gz-gui #395

ign -> gz Header Migration : gz-gui #395

Conversation

methylDragon commented May 6, 2022

chapulina May 9, 2022

Choose a reason for hiding this comment

methylDragon May 12, 2022

Choose a reason for hiding this comment

chapulina May 12, 2022

Choose a reason for hiding this comment

chapulina May 9, 2022

Choose a reason for hiding this comment

codecov bot commented May 11, 2022 • edited Loading

Codecov Report

chapulina left a comment

Choose a reason for hiding this comment

chapulina left a comment

Choose a reason for hiding this comment

codecov bot commented May 11, 2022 •

edited

Loading