Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign -> gz] CMake functions #422

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[ign -> gz] CMake functions #422

merged 1 commit into from
Jun 17, 2022

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label Jun 16, 2022
@chapulina chapulina requested a review from jennuine as a code owner June 16, 2022 21:23
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #422 (4ffaa9e) into main (2c5d186) will increase coverage by 34.12%.
The diff coverage is 47.32%.

@@             Coverage Diff             @@
##             main     #422       +/-   ##
===========================================
+ Coverage   30.03%   64.15%   +34.12%     
===========================================
  Files          43       45        +2     
  Lines        1888     5518     +3630     
===========================================
+ Hits          567     3540     +2973     
- Misses       1321     1978      +657     
Impacted Files Coverage Δ
include/gz/gui/GuiEvents.hh 100.00% <ø> (ø)
include/gz/gui/Helpers.hh 77.77% <ø> (ø)
include/gz/gui/MainWindow.hh 100.00% <ø> (ø)
include/gz/gui/Plugin.hh 100.00% <ø> (ø)
src/Dialog.cc 68.42% <0.00%> (ø)
src/DragDropModel.cc 100.00% <ø> (ø)
src/SearchModel.cc 96.55% <ø> (ø)
...interactive_view_control/InteractiveViewControl.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalScene.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalSceneRhi.cc 0.00% <ø> (ø)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70300b...4ffaa9e. Read the comment docs.

Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack builds with this 👌

@methylDragon
Copy link
Contributor

methylDragon commented Jun 17, 2022

Note:
I'm not sure if I saw: 39 - INTEGRATION_Examples_TEST (Subprocess aborted) before

It definitely didn't appear in the env var PR: https://github.com/gazebosim/gz-gui/runs/6766316540?check_suite_focus=true

@chapulina
Copy link
Contributor Author

I'm not sure if I saw: 39 - INTEGRATION_Examples_TEST (Subprocess aborted) before

That's flaky, it may be better once we forward-port #419 🤞🏽 One way to verify this is that it failed in one of the Jammy builds but not the other.

@chapulina chapulina merged commit d421cfa into main Jun 17, 2022
@chapulina chapulina deleted the chapulina/7/cmake_gz branch June 17, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants