-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ign -> gz] CMake functions #422
Conversation
chapulina
commented
Jun 16, 2022
- Part of CMake API from ign to gz gazebo-tooling/release-tools#719
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #422 +/- ##
===========================================
+ Coverage 30.03% 64.15% +34.12%
===========================================
Files 43 45 +2
Lines 1888 5518 +3630
===========================================
+ Hits 567 3540 +2973
- Misses 1321 1978 +657
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stack builds with this 👌
Note: It definitely didn't appear in the env var PR: https://github.com/gazebosim/gz-gui/runs/6766316540?check_suite_focus=true |
That's flaky, it may be better once we forward-port #419 🤞🏽 One way to verify this is that it failed in one of the Jammy builds but not the other. |