Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Scene3d plugin #438

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Remove deprecated Scene3d plugin #438

merged 2 commits into from
Jul 20, 2022

Conversation

chapulina
Copy link
Contributor

Summary

Scene3D is deprecated on Fortress (tick), now we remove it on Garden (tock).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from jennuine as a code owner July 20, 2022 20:29
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 20, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouh yes!

Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #438 (f9ad2d4) into main (02cb9fd) will increase coverage by 2.40%.
The diff coverage is 69.64%.

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   64.07%   66.47%   +2.40%     
==========================================
  Files          45       44       -1     
  Lines        5539     4740     -799     
==========================================
- Hits         3549     3151     -398     
+ Misses       1990     1589     -401     
Impacted Files Coverage Δ
include/gz/gui/GuiEvents.hh 100.00% <ø> (ø)
include/gz/gui/Helpers.hh 77.77% <ø> (ø)
include/gz/gui/Plugin.hh 100.00% <ø> (ø)
src/Application.cc 84.82% <ø> (ø)
src/gz.cc 42.85% <ø> (ø)
src/plugins/camera_tracking/CameraTracking.cc 68.45% <ø> (ø)
src/plugins/grid_config/GridConfig.cc 22.35% <ø> (ø)
src/plugins/grid_config/GridConfig.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalScene.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalSceneRhi.cc 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f7ba5...f9ad2d4. Read the comment docs.

@chapulina chapulina enabled auto-merge (squash) July 20, 2022 21:51
@chapulina chapulina merged commit eeb7244 into main Jul 20, 2022
@chapulina chapulina deleted the chapulina/7/rm_scene3d branch July 20, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants