Add render event #70
Merged
Add render event #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create new render event type * Sends render event after each render call Signed-off-by: Sarathkrishnan Ramesh <[email protected]>
chapulina
reviewed
Jun 2, 2020
There was a problem hiding this comment.
Sweet! Thanks for picking up the issue and solving it so quickly!
There are a few cppcheck warnings, mind fixing them?
https://build.osrfoundation.org/job/ignition_gui-ci-pr_any-ubuntu_auto-amd64/301/cppcheckResult/
Signed-off-by: Sarathkrishnan Ramesh <[email protected]>
chapulina
reviewed
Jun 8, 2020
Signed-off-by: Sarathkrishnan Ramesh <[email protected]>
chapulina
approved these changes
Jun 8, 2020
chapulina
added a commit
that referenced
this pull request
Aug 29, 2020
Signed-off-by: Sarathkrishnan Ramesh <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
chapulina
added a commit
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Sarathkrishnan Ramesh <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new render event type
Sends render event after each render call
Signed-off-by: Sarathkrishnan Ramesh [email protected]
Reference to issue #68