Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps for Dome: use msgs6, transport9 #92

Merged
merged 4 commits into from
Jul 27, 2020
Merged

Update deps for Dome: use msgs6, transport9 #92

merged 4 commits into from
Jul 27, 2020

Conversation

j-rivero
Copy link
Contributor

As part of the works of gazebo-tooling/gazebodistro#5 bump the use of msgs to major version 6 and transport to 9

@j-rivero j-rivero requested a review from chapulina as a code owner July 10, 2020 12:09
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jul 10, 2020
@j-rivero
Copy link
Contributor Author

CI is going to need gazebosim/gz-transport#149 and osrf/homebrew-simulation#1063 for Brew

chapulina
chapulina approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once CI and deps are in.

@chapulina
bump deps on actions CI
5d1428a 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Jul 21, 2020
Merged
@chapulina
trigger CI
77b611c 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

CI results:

  • Jenkins Ubuntu has more errors than expected, with lots of errors that "Could not connect to any X display." @j-rivero , do we need to mark ign-gui CI with some label that requires X?
  • OSX and Windows don't have any new failures
  • Actons is failing because libignition-transport9-dev is not released on Bionic for nightlies.

@j-rivero
Copy link
Contributor Author

@osrf-jenkins run tests please

@j-rivero
Copy link
Contributor Author

CI results:

* Jenkins Ubuntu has more errors than expected, with lots of errors that "_Could not connect to any X display._" @j-rivero , do we need to mark `ign-gui` CI with some label that requires X?

It was a temporary problem on the node, is passing now.

* Actons is failing because `libignition-transport9-dev` is not released on Bionic for nightlies.

Released today. I've rerun the actions but they are failing because the tests need a GUI display I think.

@chapulina
try to fix display
b88251f 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

@chapulina
Copy link
Contributor

I've rerun the actions but they are failing because the tests need a GUI display I think.

Yup, I tried something similar to gazebosim/gz-rendering#115 but it didn't help. I guess we can merge this an follow up on this issue: #58

@j-rivero j-rivero merged commit 1e344fa into master Jul 27, 2020
@j-rivero j-rivero deleted the update_dome_versions branch July 27, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @chapulina