Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unsubscribing from a topic #107

Merged
merged 4 commits into from
Apr 12, 2021
Merged

Support unsubscribing from a topic #107

merged 4 commits into from
Apr 12, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 5, 2021

🎉 New feature

Summary

Support websocket topic unsubscribe.

Test it

Test using: https://gitlab.com/ignitionrobotics/web/app/-/tree/topic_unsubscribe

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Apr 5, 2021
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #107 (5a4209d) into ign-launch3 (9201695) will not change coverage.
The diff coverage is n/a.

❗ Current head 5a4209d differs from pull request most recent head 73e8943. Consider uploading reports for the commit 73e8943 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch3     #107   +/-   ##
============================================
  Coverage        30.24%   30.24%           
============================================
  Files                3        3           
  Lines              734      734           
============================================
  Hits               222      222           
  Misses             512      512           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9201695...73e8943. Read the comment docs.

Nate Koenig added 2 commits April 9, 2021 10:06
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from iche033 April 9, 2021 17:14
@german-e-mas
Copy link
Contributor

Currently testing this on the client. Thanks for updating it with ign-launch3, I was missing the topic_types message.

Signed-off-by: Nate Koenig <[email protected]>
Copy link
Contributor

@german-e-mas german-e-mas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nkoenig nkoenig merged commit 0d8b9a3 into ign-launch3 Apr 12, 2021
@nkoenig nkoenig deleted the websocket_unsub branch April 12, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants