Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header to image msg #109

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Add header to image msg #109

merged 2 commits into from
Apr 19, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 13, 2021

Signed-off-by: Ian Chen [email protected]

Summary

This is needed by the web-app when decoding the msg.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from nkoenig as a code owner April 13, 2021 20:57
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #109 (b3acc63) into ign-launch3 (460cfa8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch3     #109   +/-   ##
============================================
  Coverage        30.24%   30.24%           
============================================
  Files                3        3           
  Lines              734      734           
============================================
  Hits               222      222           
  Misses             512      512           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460cfa8...b3acc63. Read the comment docs.

@german-e-mas
Copy link
Contributor

I'm trying to review this, but after building and trying to run, I get the following:

Error: Version mismatch. Your configuration file version is
            [3.2.0] but libignition-launch3.so version is [3.1.1].

What configuration file is this? Any ideas of what might be wrong?

@german-e-mas
Copy link
Contributor

I'm trying to review this, but after building and trying to run, I get the following:

Error: Version mismatch. Your configuration file version is
            [3.2.0] but libignition-launch3.so version is [3.1.1].

What configuration file is this? Any ideas of what might be wrong?

Changed the version of the CMakeLists on my local branch to 3.2.0 and that made it work. Still not sure what happened.

PR looks good!

@iche033
Copy link
Contributor Author

iche033 commented Apr 15, 2021

the branch was outdated. I just merged with the latest ign-launch3 branch. b3acc63. It should be on ign-launch 3.2.0 now

@german-e-mas
Copy link
Contributor

the branch was outdated. I just merged with the latest ign-launch3 branch. b3acc63. It should be on ign-launch 3.2.0 now

Thank you!

@nkoenig nkoenig merged commit 4a3bb96 into ign-launch3 Apr 19, 2021
@nkoenig nkoenig deleted the image_header branch April 19, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants