Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spammy CMake message #142

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Remove spammy CMake message #142

merged 1 commit into from
Oct 19, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel [email protected]

🦟 Bug fix

Summary

Introduced in #121

It goes to stderr:

--- stderr: ignition-launch5                                                                                  
launch_exe_location ../../../lib/ignition/launch5/$<TARGET_FILE_NAME:ign-launch>
---
Finished <<< ignition-launch5 [13.5s]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #142 (1e90297) into ign-launch5 (8668a50) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch5     #142   +/-   ##
============================================
  Coverage        32.92%   32.92%           
============================================
  Files                4        4           
  Lines              817      817           
============================================
  Hits               269      269           
  Misses             548      548           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8668a50...1e90297. Read the comment docs.

@ahcorde ahcorde enabled auto-merge (squash) October 19, 2021 07:39
@chapulina chapulina merged commit 26ef785 into ign-launch5 Oct 19, 2021
@chapulina chapulina deleted the chapulina/msg branch October 19, 2021 15:41
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants