Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Environment Variable Migration : gz-launch #165

Merged
merged 2 commits into from
Jun 7, 2022
Merged

ign -> gz Environment Variable Migration : gz-launch #165

merged 2 commits into from
Jun 7, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 4, 2022
Closed
49 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 4, 2022
@codecov
Copy link

codecov bot commented Jun 4, 2022 •
edited
Loading

Codecov Report

Merging #165 (bf126ec) into main (8a74fac) will increase coverage by 32.40%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           main     #165       +/-   ##
=========================================
+ Coverage      0   32.40%   +32.40%     
=========================================
  Files         0        4        +4     
  Lines         0      830      +830     
=========================================
+ Hits          0      269      +269     
- Misses        0      561      +561
Impacted Files Coverage Δ
src/cmd/launch_main.cc 69.11% <0.00%> (ø)
src/cmd/ign.cc 80.00% <0.00%> (ø)
src/Manager.cc 53.77% <0.00%> (ø)
src/vendor/backward.hpp 8.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a74fac...bf126ec. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 6, 2022
chapulina
chapulina suggested changes Jun 7, 2022
View reviewed changes
src/cmd/launch_main.cc Outdated Show resolved Hide resolved
@methylDragon methylDragon changed the title ign -> gz Namespace Migration : gz-launch ign -> gz Environment Variable Migration : gz-launch Jun 7, 2022
@methylDragon
Reword deprecation warning
bf126ec 
Signed-off-by: methylDragon <[email protected]>
@chapulina chapulina merged commit e8c9dc7 into main Jun 7, 2022
@chapulina chapulina deleted the env_var_migration branch June 7, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina