Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup fixes #211

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Small cleanup fixes #211

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee0061d
Small cleanup fixes
nkoenig Mar 14, 2023
1a94534
Missing colon
nkoenig Mar 17, 2023
98860c9
Fix linting
scpeters Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/ignition/launch/Plugin.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ namespace ignition
/// \brief Base class for launch plugins.
class Plugin
{
// Default destructor
public virtual ~Plugin() {};
nkoenig marked this conversation as resolved.
Show resolved Hide resolved
nkoenig marked this conversation as resolved.
Show resolved Hide resolved

/// \brief Load function that each launch plugin must implement.
/// \param[in] _elem Pointer to the XML for this plugin.
/// \return True to keep the plugin alive. Return false to have the
Expand Down
2 changes: 2 additions & 0 deletions plugins/websocket_server/MessageDefinitions.hh.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#ifndef IGNITION_LAUNCH_WEBSOCKETSERVER_MESSAGEDEFINITIONS_HH_
#define IGNITION_LAUNCH_WEBSOCKETSERVER_MESSAGEDEFINITIONS_HH_

#include <string>

namespace ignition
{
namespace launch
Expand Down