Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msvc warning #250

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix msvc warning #250

merged 1 commit into from
Mar 19, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 19, 2024

🦟 Bug fix

Summary

MSVC doesn't seem to like the use of size_t with std::seed_seq::generate. The std::seed_seq::result_type is [std::uint_least32_t](https://en.cppreference.com/w/cpp/types/integer) , and the examples all use std::uint32_t.

https://godbolt.org/z/db85bEf5z

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from nkoenig as a code owner March 19, 2024 15:20
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.62%. Comparing base (3a797f4) to head (ce26d32).

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-launch7     #250   +/-   ##
===========================================
  Coverage       58.62%   58.62%           
===========================================
  Files               3        3           
  Lines             423      423           
===========================================
  Hits              248      248           
  Misses            175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey merged commit 28c76db into gazebosim:gz-launch7 Mar 19, 2024
10 of 11 checks passed
@azeey azeey deleted the fix_warning branch March 19, 2024 18:58
Crola1702 pushed a commit that referenced this pull request May 28, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
@Crola1702 Crola1702 mentioned this pull request May 28, 2024
8 tasks
Crola1702 pushed a commit that referenced this pull request May 28, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
@Crola1702 Crola1702 mentioned this pull request May 28, 2024
8 tasks
Crola1702 pushed a commit that referenced this pull request May 28, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
Crola1702 pushed a commit that referenced this pull request May 28, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants